You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by danbroudy <no...@github.com> on 2014/11/25 22:26:14 UTC

[jclouds-labs-google] added InstanceApi.setScheduling (#101)

You can merge this Pull Request by running:

  git pull https://github.com/GoogleCloudPlatform/jclouds-labs-google setScheduling

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-labs-google/pull/101

-- Commit Summary --

  * added InstanceApi.setScheduling

-- File Changes --

    M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/GoogleComputeEngineServiceAdapter.java (5)
    M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/Instance.java (42)
    M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/NewInstance.java (11)
    M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/InstanceApi.java (20)
    M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/compute/GoogleComputeEngineServiceMockTest.java (73)
    M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/InstanceApiLiveTest.java (18)
    M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/InstanceApiMockTest.java (13)
    M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseInstanceTest.java (4)
    M google-compute-engine/src/test/resources/aggregated_instance_list.json (4)
    A google-compute-engine/src/test/resources/firewall_insert_2.json (28)
    M google-compute-engine/src/test/resources/instance_get.json (4)
    M google-compute-engine/src/test/resources/instance_insert.json (33)
    A google-compute-engine/src/test/resources/instance_insert_2.json (37)
    M google-compute-engine/src/test/resources/instance_insert_simple.json (29)
    M google-compute-engine/src/test/resources/instance_list.json (4)
    A google-compute-engine/src/test/resources/instance_set_scheduling.json (4)

-- Patch Links --

https://github.com/jclouds/jclouds-labs-google/pull/101.patch
https://github.com/jclouds/jclouds-labs-google/pull/101.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/101

Re: [jclouds-labs-google] added InstanceApi.setScheduling (#101)

Posted by Ignasi Barrera <no...@github.com>.
I'm pretty sure that those failures will be caused by the template being used, or by some misconfiguration with the ssh keys. If no one is looking at them yet I'll have a look this week.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/101#issuecomment-64667641

Re: [jclouds-labs-google] added InstanceApi.setScheduling (#101)

Posted by Adrian Cole <no...@github.com>.
Thanks. Ps do you know if anyone is looking into those 3 failures? One of
us should in the next week or so. Cc @nacx @ccustine @andreaturli

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/101#issuecomment-64661128

Re: [jclouds-labs-google] added InstanceApi.setScheduling (#101)

Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-google #1790](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1790/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/101#issuecomment-64502835

Re: [jclouds-labs-google] added InstanceApi.setScheduling (#101)

Posted by Adrian Cole <no...@github.com>.
one change I think helps. otherwise LGTM

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/101#issuecomment-64491330

Re: [jclouds-labs-google] added InstanceApi.setScheduling (#101)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #317](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/317/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/101#issuecomment-64474004

Re: [jclouds-labs-google] added InstanceApi.setScheduling (#101)

Posted by Adrian Cole <no...@github.com>.
> @@ -166,6 +198,8 @@ public static ServiceAccount create(String email, List<String> scopes) {
>        TERMINATED
>     }
>  
> +

fuzz

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/101/files#r20905897

Re: [jclouds-labs-google] added InstanceApi.setScheduling (#101)

Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-google #1788](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1788/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/101#issuecomment-64474708

Re: [jclouds-labs-google] added InstanceApi.setScheduling (#101)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #319](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/319/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/101#issuecomment-64502234

Re: [jclouds-labs-google] added InstanceApi.setScheduling (#101)

Posted by Adrian Cole <no...@github.com>.
>        assertSent(server, "GET", "/projects/party/zones/us-central1-a/operations/operation-1354084865060");
>        assertSent(server, "GET", "/projects/party/aggregated/instances");
> -      assertSent(server, "POST", "/projects/party/zones/us-central1-a/instances", "" //

agree on this. it was a mouthful and we weren't using value comparison vs inputs anyway.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/101/files#r20906049

Re: [jclouds-labs-google] added InstanceApi.setScheduling (#101)

Posted by danbroudy <no...@github.com>.
Updated and ran live test.

```
Results :

Failed tests: 
  GoogleComputeEngineServiceLiveTest>BaseComputeServiceLiveTest.testCreateAndRunAService:706->BaseComputeServiceLiveTest.createAndRunAServiceInGroup:723 » RunNodes
  GoogleComputeEngineServiceLiveTest>BaseComputeServiceLiveTest.testAScriptExecutionAfterBootWithBasicTemplate:223 » RunNodes
  GoogleComputeEngineServiceLiveTest>BaseComputeServiceLiveTest.testConcurrentUseOfComputeServiceToCreateNodes:475 » Execution

Tests run: 147, Failures: 3, Errors: 0, Skipped: 16

```

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/101#issuecomment-64502111

Re: [jclouds-labs-google] added InstanceApi.setScheduling (#101)

Posted by Adrian Cole <no...@github.com>.
> @@ -39,4 +40,16 @@ public void setDiskAutoDeleteResponseIs2xx() throws Exception {
>        assertSent(server, "POST", "/projects/party/zones/us-central1-a/instances/test-1/setDiskAutoDelete"
>            + "?deviceName=test-disk-1&autoDelete=true");
>     }
> +
> +   public void setScheduling() throws Exception {
> +      server.enqueue(jsonResponse("/zone_operation.json"));
> +
> +      InstanceApi instanceApi = api().instancesInZone("us-central1-a");
> +
> +      assertEquals(instanceApi.setScheduling("test-1", OnHostMaintenance.TERMINATE, true),
> +            new ParseZoneOperationTest().expected(url("/projects")));
> +
> +      assertSent(server, "POST", "/projects/party/zones/us-central1-a/instances/test-1/setScheduling",

I'd inline trivial (ex. <=4 field) json objects rather than creating more resource files.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/101/files#r20906005