[jira] [Commented] (SLING-8356) Increase service.ranking of ResourceTypeBasedResourcePicker

["Konrad Windszus (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-8356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16852985#comment-16852985 ] 

Konrad Windszus commented on SLING-8356:
----------------------------------------

Since in most of the use cases the ResourceTypeBasedResourcePicker should come first, I think it is reasonable to give it a service.ranking of zero. That way one can place the same amount of pickers after and before it.

> Increase service.ranking of ResourceTypeBasedResourcePicker
> -----------------------------------------------------------
>
>                 Key: SLING-8356
>                 URL: https://issues.apache.org/jira/browse/SLING-8356
>             Project: Sling
>          Issue Type: Improvement
>          Components: Extensions
>    Affects Versions: Sling Models Impl 1.4.10
>            Reporter: Konrad Windszus
>            Priority: Minor
>             Fix For: Sling Models Impl 1.4.12
>
>
> Currently the {{ResourceTypeBasedResourcePicker}} (https://github.com/apache/sling-org-apache-sling-models-impl/blob/master/src/main/java/org/apache/sling/models/impl/ResourceTypeBasedResourcePicker.java#L34) is always the 2nd last picker and the {{FirstImplementationPicker}} (https://github.com/apache/sling-org-apache-sling-models-impl/blob/master/src/main/java/org/apache/sling/models/impl/FirstImplementationPicker.java#L36) is the last picker.
> In some cases you are interested to place pickers in between (compare with https://github.com/adobe/aem-core-wcm-components/issues/546), therefore I would propose to set the {{service.ranking}} of {{ResourceTypeBasedResourcePicker}} to {{(Integer.MAX_VALUE - 1000)}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)