You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/06/03 14:29:27 UTC

[GitHub] [accumulo] keith-turner commented on a change in pull request #2118: PopulateMetadataTable Improvements

keith-turner commented on a change in pull request #2118:
URL: https://github.com/apache/accumulo/pull/2118#discussion_r644841848



##########
File path: server/manager/src/main/java/org/apache/accumulo/manager/tableOps/tableImport/PopulateMetadataTable.java
##########
@@ -121,63 +114,56 @@ static void readMappingFile(VolumeManager fs, ImportedTableInfo tableInfo, Strin
           Text currentRow = null;
           int dirCount = 0;
 
-          while (true) {
-            key.readFields(in);
-            val.readFields(in);
+          try (DataInputStream in = new DataInputStream(new BufferedInputStream(zis))) {

Review comment:
       Seems like this could close zis, which would not be desired inside the loop.    I am uncertain about the actual behavior though.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org