You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by ha...@apache.org on 2008/08/22 05:44:23 UTC

svn commit: r687935 - in /ofbiz/trunk/applications/order: config/OrderUiLabels.xml webapp/ordermgr/request/RequestForms.xml

Author: hansbak
Date: Thu Aug 21 20:44:23 2008
New Revision: 687935

URL: http://svn.apache.org/viewvc?rev=687935&view=rev
Log:
correction on label reported by Jacques and make the text box bigger on a request note

Modified:
    ofbiz/trunk/applications/order/config/OrderUiLabels.xml
    ofbiz/trunk/applications/order/webapp/ordermgr/request/RequestForms.xml

Modified: ofbiz/trunk/applications/order/config/OrderUiLabels.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/config/OrderUiLabels.xml?rev=687935&r1=687934&r2=687935&view=diff
==============================================================================
--- ofbiz/trunk/applications/order/config/OrderUiLabels.xml (original)
+++ ofbiz/trunk/applications/order/config/OrderUiLabels.xml Thu Aug 21 20:44:23 2008
@@ -9004,7 +9004,7 @@
         <value xml:lang="th">หัวข้อการร้องขอ</value>
         <value xml:lang="zh">请求明细</value>
     </property>
-    <property key="PageTitleRequestItems">
+    <property key="PageTitleRequestItemNotes">
         <value xml:lang="en">Request Item Notes</value>
     </property>
     <property key="PageTitleRequestRoles">

Modified: ofbiz/trunk/applications/order/webapp/ordermgr/request/RequestForms.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/webapp/ordermgr/request/RequestForms.xml?rev=687935&r1=687934&r2=687935&view=diff
==============================================================================
--- ofbiz/trunk/applications/order/webapp/ordermgr/request/RequestForms.xml (original)
+++ ofbiz/trunk/applications/order/webapp/ordermgr/request/RequestForms.xml Thu Aug 21 20:44:23 2008
@@ -377,7 +377,7 @@
         header-row-style="header-row" default-table-style="basic-table">
         <field name="custRequestId"><hidden/></field>
         <field name="custRequestItemSeqId"><hidden/></field>
-        <field name="note"><textarea/></field>
+        <field name="note"><textarea cols="60" rows="10"/></field>
         <field name="submitButton" title="${uiLabelMap.CommonSubmit}" widget-style="smallSubmit">
             <submit button-type="button"/>
         </field>

Re: svn commit: r687935 - in /ofbiz/trunk/applications/order: config/OrderUiLabels.xml webapp/ordermgr/request/RequestForms.xml

Posted by Jacques Le Roux <ja...@les7arts.com>.
Fixed in revision 688695.

Jacques

From: "Jacques Le Roux" <ja...@les7arts.com>
> Hi Hans,
>
> Sorry, but it seems a bit more complicated :/
>
> Below you introduced a new PageTitleRequestItemNotes but there is already a such label in this file. BTW <property 
> key="PageTitleRequestItems"> is not properly placed. It should be above the pre-existing PageTitleRequestItemNotes which is for 
> now the 1st of this "group" of labels (beginning by PageTitleRequestItem I mean). I guess this not well sorted state is the source 
> of your troubles.
>
> In r687279 you introduced a PageTitleRequestItems (note the s at end). So I wondered if you need PageTitleRequestItemsNotes (note 
> the s at end ot Items) instead of PageTitleRequestItemNotes ?
>
> Jacques
>
>> Author: hansbak
>> Date: Thu Aug 21 20:44:23 2008
>> New Revision: 687935
>>
>> URL: http://svn.apache.org/viewvc?rev=687935&view=rev
>> Log:
>> correction on label reported by Jacques and make the text box bigger on a request note
>>
>> Modified:
>>    ofbiz/trunk/applications/order/config/OrderUiLabels.xml
>>    ofbiz/trunk/applications/order/webapp/ordermgr/request/RequestForms.xml
>>
>> Modified: ofbiz/trunk/applications/order/config/OrderUiLabels.xml
>> URL: 
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/config/OrderUiLabels.xml?rev=687935&r1=687934&r2=687935&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/applications/order/config/OrderUiLabels.xml (original)
>> +++ ofbiz/trunk/applications/order/config/OrderUiLabels.xml Thu Aug 21 20:44:23 2008
>> @@ -9004,7 +9004,7 @@
>>         <value xml:lang="th">หัวข้อการร้องขอ</value>
>>         <value xml:lang="zh">请求明细</value>
>>     </property>
>> -    <property key="PageTitleRequestItems">
>> +    <property key="PageTitleRequestItemNotes">
>>         <value xml:lang="en">Request Item Notes</value>
>>     </property>
>>     <property key="PageTitleRequestRoles">
>>
>> Modified: ofbiz/trunk/applications/order/webapp/ordermgr/request/RequestForms.xml
>> URL: 
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/webapp/ordermgr/request/RequestForms.xml?rev=687935&r1=687934&r2=687935&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/applications/order/webapp/ordermgr/request/RequestForms.xml (original)
>> +++ ofbiz/trunk/applications/order/webapp/ordermgr/request/RequestForms.xml Thu Aug 21 20:44:23 2008
>> @@ -377,7 +377,7 @@
>>         header-row-style="header-row" default-table-style="basic-table">
>>         <field name="custRequestId"><hidden/></field>
>>         <field name="custRequestItemSeqId"><hidden/></field>
>> -        <field name="note"><textarea/></field>
>> +        <field name="note"><textarea cols="60" rows="10"/></field>
>>         <field name="submitButton" title="${uiLabelMap.CommonSubmit}" widget-style="smallSubmit">
>>             <submit button-type="button"/>
>>         </field>
>>
>>
>

Re: svn commit: r687935 - in /ofbiz/trunk/applications/order: config/OrderUiLabels.xml webapp/ordermgr/request/RequestForms.xml

Posted by Jacques Le Roux <ja...@les7arts.com>.
Hi Hans,

Sorry, but it seems a bit more complicated :/

Below you introduced a new PageTitleRequestItemNotes but there is already a such label in this file. BTW <property 
key="PageTitleRequestItems"> is not properly placed. It should be above the pre-existing PageTitleRequestItemNotes which is for now 
the 1st of this "group" of labels (beginning by PageTitleRequestItem I mean). I guess this not well sorted state is the source of 
your troubles.

In r687279 you introduced a PageTitleRequestItems (note the s at end). So I wondered if you need PageTitleRequestItemsNotes (note 
the s at end ot Items) instead of PageTitleRequestItemNotes ?

Jacques

> Author: hansbak
> Date: Thu Aug 21 20:44:23 2008
> New Revision: 687935
>
> URL: http://svn.apache.org/viewvc?rev=687935&view=rev
> Log:
> correction on label reported by Jacques and make the text box bigger on a request note
>
> Modified:
>    ofbiz/trunk/applications/order/config/OrderUiLabels.xml
>    ofbiz/trunk/applications/order/webapp/ordermgr/request/RequestForms.xml
>
> Modified: ofbiz/trunk/applications/order/config/OrderUiLabels.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/config/OrderUiLabels.xml?rev=687935&r1=687934&r2=687935&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/order/config/OrderUiLabels.xml (original)
> +++ ofbiz/trunk/applications/order/config/OrderUiLabels.xml Thu Aug 21 20:44:23 2008
> @@ -9004,7 +9004,7 @@
>         <value xml:lang="th">หัวข้อการร้องขอ</value>
>         <value xml:lang="zh">请求明细</value>
>     </property>
> -    <property key="PageTitleRequestItems">
> +    <property key="PageTitleRequestItemNotes">
>         <value xml:lang="en">Request Item Notes</value>
>     </property>
>     <property key="PageTitleRequestRoles">
>
> Modified: ofbiz/trunk/applications/order/webapp/ordermgr/request/RequestForms.xml
> URL: 
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/webapp/ordermgr/request/RequestForms.xml?rev=687935&r1=687934&r2=687935&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/order/webapp/ordermgr/request/RequestForms.xml (original)
> +++ ofbiz/trunk/applications/order/webapp/ordermgr/request/RequestForms.xml Thu Aug 21 20:44:23 2008
> @@ -377,7 +377,7 @@
>         header-row-style="header-row" default-table-style="basic-table">
>         <field name="custRequestId"><hidden/></field>
>         <field name="custRequestItemSeqId"><hidden/></field>
> -        <field name="note"><textarea/></field>
> +        <field name="note"><textarea cols="60" rows="10"/></field>
>         <field name="submitButton" title="${uiLabelMap.CommonSubmit}" widget-style="smallSubmit">
>             <submit button-type="button"/>
>         </field>
>
>