[GitHub] [incubator-nuttx] hartmannathan commented on pull request #2273: stm32/stm32_spi: Add SPI register definitions for STM32G47xxx

[GitBox <gi...@apache.org>]

hartmannathan commented on pull request #2273:
URL: https://github.com/apache/incubator-nuttx/pull/2273#issuecomment-725411003


   On Wed, Nov 11, 2020 at 7:27 AM David Sidrane <no...@github.com>
   wrote:
   
   > *@davids5* requested changes on this pull request.
   >
   > What is value in having this in Kconfig?
   > ------------------------------
   >
   > In arch/arm/src/stm32/Kconfig
   > <https://github.com/apache/incubator-nuttx/pull/2273#discussion_r521322607>
   > :
   >
   > > @@ -2417,6 +2417,22 @@ config STM32_HAVE_IP_DMA_V2
   >  	bool
   >  	default n
   >
   > +config STM32_HAVE_IP_SPI_V1
   >
   > These are data sheet dependent and invariant. Why not encapsulate it in
   > the chip.h? Leaving it up the the end user requires them to do work that
   > was already done when an new SoC is added.
   >
   
   The end user does not have to do anything. For all the STM32 chips,
   peripheral IP versions are selected in Kconfig. See the similar
   automatically-selected configs for other peripherals' versions. Putting
   this one in chip.h would be a departure from how it is already being done
   for all other peripherals.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org