[GitHub] [incubator-pinot] npawar commented on a change in pull request #5642: Add more schema validations

[GitBox <gi...@apache.org>]

npawar commented on a change in pull request #5642:
URL: https://github.com/apache/incubator-pinot/pull/5642#discussion_r450457863



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java
##########
@@ -354,7 +354,7 @@ private boolean isValid(Schema schema, IndexingConfig indexingConfig) {
       }
     }
     // 2. We want to get the schema errors, if any, even if isValid is false;
-    if (!SchemaUtils.validate(schema, _logger)) {
+    if (!SchemaUtils.validate(schema, false, _logger)) {

Review comment:
       the schema used here is the one from zk metadata. The field names validation will already have been performed when the schema was added or updated. 
   If the user skipped validating reserved keywords when adding/updating schema, then we will have reserved keywords in this schema. Hence, at this point, we should not enforce further field names validations, as we don't know if those are intentional or not.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org