You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "barkanias (via GitHub)" <gi...@apache.org> on 2024/01/17 08:36:16 UTC

[I] [Feature Request]: Request for Addition of "ImagePullSecrets" in Helm Chart Templates for Private Repo Support [incubator-devlake-helm-chart]

barkanias opened a new issue, #231:
URL: https://github.com/apache/incubator-devlake-helm-chart/issues/231

   Hi,
   
   I am currently facing an issue while attempting to upload the DevLake chart to a private repository and subsequently pulling the image from that repository. The templates within the charts lack the "ImagePullSecrets" value, which is preventing efficient integration with private repositories.
   
   I kindly request the addition of the "ImagePullSecrets" value to the Helm chart templates. This enhancement is crucial for enabling the use of the chart from a private repository within our company.
   
   Thanks in advanced. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Feature Request]: Request for Addition of "ImagePullSecrets" in Helm Chart Templates for Private Repo Support [incubator-devlake-helm-chart]

Posted by "JorgeGar (via GitHub)" <gi...@apache.org>.
JorgeGar commented on issue #231:
URL: https://github.com/apache/incubator-devlake-helm-chart/issues/231#issuecomment-1900208082

   Hi @Startrekzky, adding the ImagePullSecrects could be a nice benefit for all those who need it. If we were to do it, we should also include the option of creating the secrets themselves too, which most likely requires some work on the helper. Let's also see whatn @matrixji thinks about it.
   I would suggest @barkanias to draft a PR if that's fine with everyone 😄 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Feature Request]: Request for Addition of "ImagePullSecrets" in Helm Chart Templates for Private Repo Support [incubator-devlake-helm-chart]

Posted by "matrixji (via GitHub)" <gi...@apache.org>.
matrixji commented on issue #231:
URL: https://github.com/apache/incubator-devlake-helm-chart/issues/231#issuecomment-1900426213

   ImagePullSecrects is the missing part right now,  it should be very useful for devlake users. Agree with @JorgeGar we may also need an auto-create-secret option.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Feature Request]: Request for Addition of "ImagePullSecrets" in Helm Chart Templates for Private Repo Support [incubator-devlake-helm-chart]

Posted by "Startrekzky (via GitHub)" <gi...@apache.org>.
Startrekzky commented on issue #231:
URL: https://github.com/apache/incubator-devlake-helm-chart/issues/231#issuecomment-1899984267

   Hi @JorgeGar and @matrixji , I would like to know your thoughts on this proposal. Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Feature Request]: Request for Addition of "ImagePullSecrets" in Helm Chart Templates for Private Repo Support [incubator-devlake-helm-chart]

Posted by "Startrekzky (via GitHub)" <gi...@apache.org>.
Startrekzky commented on issue #231:
URL: https://github.com/apache/incubator-devlake-helm-chart/issues/231#issuecomment-1910030886

   Cool. Since I'm not an expert, may I ask if any of you (@matrixji @JorgeGar @ZhangNing10 @barkanias)  are interested in putting up a PR for this? What is the estimated workload for this by the way?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org