You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/07/09 08:23:38 UTC
[GitHub] [camel-k] tadayosi opened a new pull request #2489: fix(cli): kamel uninstall should delete kamelets #2479
tadayosi opened a new pull request #2489:
URL: https://github.com/apache/camel-k/pull/2489
<!-- Description -->
Fix #2479
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
`kamel uninstall` now also cleans up all kamelets defined in the same namespace.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on pull request #2489: fix(cli): kamel uninstall should delete kamelets #2479
Posted by GitBox <gi...@apache.org>.
tadayosi commented on pull request #2489:
URL: https://github.com/apache/camel-k/pull/2489#issuecomment-877032234
Reconsidering it, now I think it's better for `kamel uninstall` to keep user-defined kamelets untouched whether or not `--skip-kamelets` is enabled, rather than erasing them altogether as Luca suggests. Users can manage your own set of kamelets with `kamel kamelet` subcommands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] lburgazzoli commented on pull request #2489: fix(cli): kamel uninstall should delete kamelets #2479
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on pull request #2489:
URL: https://github.com/apache/camel-k/pull/2489#issuecomment-877013761
@nicolaferraro @tadayosi wonder if we should delete all the kamelets or only those that have been installed as part of the operator installation as the user may have installed its own set of kamelets that I guess, should not be deleted as part of the uninstall process
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on pull request #2489: fix(cli): kamel uninstall should delete kamelets #2479
Posted by GitBox <gi...@apache.org>.
tadayosi commented on pull request #2489:
URL: https://github.com/apache/camel-k/pull/2489#issuecomment-877024368
@lburgazzoli FYI this pull req also introduces `--skip-kamelets` option. Maybe we can activate the option by default or introduce another option `--skip-user-kamelets` with `true` by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] nicolaferraro merged pull request #2489: fix(cli): kamel uninstall should delete kamelets #2479
Posted by GitBox <gi...@apache.org>.
nicolaferraro merged pull request #2489:
URL: https://github.com/apache/camel-k/pull/2489
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org