[GitHub] [jackrabbit-filevault] tripodsan commented on a change in pull request #181: Bugfix/jcrvlt 549

[GitBox <gi...@apache.org>]

tripodsan commented on a change in pull request #181:
URL: https://github.com/apache/jackrabbit-filevault/pull/181#discussion_r748024131



##########
File path: vault-core/src/test/java/org/apache/jackrabbit/vault/packaging/integration/MandatoryNodeIT.java
##########
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.jackrabbit.vault.packaging.integration;
+
+import java.io.IOException;
+
+import javax.jcr.RepositoryException;
+import org.apache.jackrabbit.vault.packaging.PackageException;
+import org.junit.Test;
+
+
+public class MandatoryNodeIT extends IntegrationTestBase {
+ 
+    @Test
+    public void testMandatoryChildNodesReplace()
+            throws RepositoryException, IOException, PackageException {
+
+        // package set ups folder structure with mandatory child nodes
+        extractVaultPackage("/test-packages/wcm-rollout-config-1.zip");
+
+        assertNodeExists("/libs/msm/wcm/rolloutconfigs/activate/targetActivate");
+
+        assertNodeExists("/libs/msm/wcm/rolloutconfigs/deactivate/targetDeactivate");
+
+        assertNodeExists("/libs/msm/wcm/rolloutconfigs/default/contentUpdate");
+        assertNodeExists("/libs/msm/wcm/rolloutconfigs/default/contentCopy");
+        assertNodeExists("/libs/msm/wcm/rolloutconfigs/default/contentDelete");
+
+        // packages removes/replaces some mandatory child nodes
+        extractVaultPackage("/test-packages/wcm-rollout-config-2.zip");
+
+        // check if older nodes are replaced
+        assertNodeMissing("/libs/msm/wcm/rolloutconfigs/default/contentUpdate");
+        assertNodeMissing("/libs/msm/wcm/rolloutconfigs/default/contentDelete");
+        // check if newly added node exist
+        assertNodeExists("/libs/msm/wcm/rolloutconfigs/default/activate");
+        assertNodeExists("/libs/msm/wcm/rolloutconfigs/default/contentCopy");
+
+        // check if the only node is replaced
+        assertNodeMissing("/libs/msm/wcm/rolloutconfigs/activate/targetActivate");
+        assertNodeExists("/libs/msm/wcm/rolloutconfigs/activate/targetNewActivate");
+
+        // check if the only node is still there (although not part of 2nd package)
+        assertNodeExists("/libs/msm/wcm/rolloutconfigs/deactivate/targetDeactivate");

Review comment:
       maybe we can relax the check and only reject the removal of the mandatory childnode, if it's a single node (eg, for a mandatory nt:resource). I think the _at least 1_ behaviour is rare...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org