[GitHub] [iceberg] ajantha-bhat commented on a diff in pull request #6661: Core: Support delete file stats in partitions metadata table

["ajantha-bhat (via GitHub)" <gi...@apache.org>]

ajantha-bhat commented on code in PR #6661:
URL: https://github.com/apache/iceberg/pull/6661#discussion_r1087862183


##########
core/src/main/java/org/apache/iceberg/PartitionsTable.java:
##########
@@ -47,7 +48,11 @@ public class PartitionsTable extends BaseMetadataTable {
             Types.NestedField.required(1, "partition", Partitioning.partitionType(table)),
             Types.NestedField.required(2, "record_count", Types.LongType.get()),

Review Comment:
   I would like to rename `record_count` to `data_record_count` and `file_count` to `data_file_count` to convey a clear message that these stats are not the effective/overall file and record count but just for the data files. 
   
   Not in this PR but as an immediate follow-up PR as I want to keep the review effort to be minimal. 



##########
core/src/main/java/org/apache/iceberg/PartitionsTable.java:
##########
@@ -47,7 +48,11 @@ public class PartitionsTable extends BaseMetadataTable {
             Types.NestedField.required(1, "partition", Partitioning.partitionType(table)),
             Types.NestedField.required(2, "record_count", Types.LongType.get()),
             Types.NestedField.required(3, "file_count", Types.IntegerType.get()),
-            Types.NestedField.required(4, "spec_id", Types.IntegerType.get()));

Review Comment:
   I thought moving the spec-id to the last looks cleaner as all the stats will be together. 
   
   As these are not stored tables and are computed freshly on a query, I thought no need to worry about compatibility. Let me know If I am wrong. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org