You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Dag H. Wanvik (JIRA)" <ji...@apache.org> on 2007/11/08 18:56:50 UTC

[jira] Created: (DERBY-3191) SQL roles: add upgrade support

SQL roles: add upgrade support
------------------------------

                 Key: DERBY-3191
                 URL: https://issues.apache.org/jira/browse/DERBY-3191
             Project: Derby
          Issue Type: Improvement
            Reporter: Dag H. Wanvik


Derby roles introduce a new system catalog (SYSROLES). When a database
is hard upgraded, this catalog needs to be added.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-3191) SQL roles: add upgrade support

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dag H. Wanvik updated DERBY-3191:
---------------------------------

    Attachment: DERBY-3191.stat
                DERBY-3191.diff

Attaching  a first rev of a patch for upgrade support and upgrade test
for roles.

Description:
 
M      java/engine/org/apache/derby/impl/sql/catalog/DD_Version.java

This contains the upgrade action which adds SYS.SYSROLES at upgrade time.

M      java/testing/org/apache/derbyTesting/functionTests/tests/upgradeTests/Changes10_4.java

Two new tests to verify that roles can be created and dropped after upgrade. 

M      java/testing/org/apache/derbyTesting/functionTests/tests/upgradeTests/PhaseChanger.java
M      java/testing/org/apache/derbyTesting/functionTests/tests/upgradeTests/UpgradeRun.java
M      java/testing/org/apache/derbyTesting/junit/TestConfiguration.java

Changes testing framework to allow an additional database
("ROLES_10_4") in upgrade tests to be used which requires
sqlAuthorization.

Regression tests ran ok, including ugrade tests. I ran using
these releases in my derbyTesting.oldReleasePath:

10.0.2.1
10.1.1.0
10.1.2.1
10.1.3.1
10.2.1.6
10.2.2.0
10.3.1.4


> SQL roles: add upgrade support
> ------------------------------
>
>                 Key: DERBY-3191
>                 URL: https://issues.apache.org/jira/browse/DERBY-3191
>             Project: Derby
>          Issue Type: Improvement
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>         Attachments: DERBY-3191.diff, DERBY-3191.stat
>
>
> Derby roles introduce a new system catalog (SYSROLES). When a database
> is hard upgraded, this catalog needs to be added.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-3191) SQL roles: add upgrade support

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dag H. Wanvik updated DERBY-3191:
---------------------------------

    Attachment: DERBY-3191b.stat
                DERBY-3191b.diff

Uploading DERBY-3191b.* which addresses Rick's comment
plus fixed some whitespace inconsistencies.

> SQL roles: add upgrade support
> ------------------------------
>
>                 Key: DERBY-3191
>                 URL: https://issues.apache.org/jira/browse/DERBY-3191
>             Project: Derby
>          Issue Type: Improvement
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>         Attachments: DERBY-3191.diff, DERBY-3191.stat, DERBY-3191b.diff, DERBY-3191b.stat
>
>
> Derby roles introduce a new system catalog (SYSROLES). When a database
> is hard upgraded, this catalog needs to be added.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-3191) SQL roles: add upgrade support

Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543927 ] 

Rick Hillegas commented on DERBY-3191:
--------------------------------------

Thanks for the patch, Dag. Sorry to let it languish on the queue so long. It looks good to me. I have one stylistic comment which you can dismiss as a religious quirk: The inner class AdditionalDb has a field called "noShutdown". The variable is referenced once just by itself and once with a ! prepended. I  always stumble over double negatives like "not noShutdown". Regards-Rick

> SQL roles: add upgrade support
> ------------------------------
>
>                 Key: DERBY-3191
>                 URL: https://issues.apache.org/jira/browse/DERBY-3191
>             Project: Derby
>          Issue Type: Improvement
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>         Attachments: DERBY-3191.diff, DERBY-3191.stat
>
>
> Derby roles introduce a new system catalog (SYSROLES). When a database
> is hard upgraded, this catalog needs to be added.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-3191) SQL roles: add upgrade support

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dag H. Wanvik updated DERBY-3191:
---------------------------------

    Component/s: SQL
                 Security

> SQL roles: add upgrade support
> ------------------------------
>
>                 Key: DERBY-3191
>                 URL: https://issues.apache.org/jira/browse/DERBY-3191
>             Project: Derby
>          Issue Type: Improvement
>          Components: Security, SQL
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>             Fix For: 10.4.0.0
>
>         Attachments: DERBY-3191.diff, DERBY-3191.stat, DERBY-3191b.diff, DERBY-3191b.stat
>
>
> Derby roles introduce a new system catalog (SYSROLES). When a database
> is hard upgraded, this catalog needs to be added.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (DERBY-3191) SQL roles: add upgrade support

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dag H. Wanvik reassigned DERBY-3191:
------------------------------------

    Assignee: Dag H. Wanvik

> SQL roles: add upgrade support
> ------------------------------
>
>                 Key: DERBY-3191
>                 URL: https://issues.apache.org/jira/browse/DERBY-3191
>             Project: Derby
>          Issue Type: Improvement
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>
> Derby roles introduce a new system catalog (SYSROLES). When a database
> is hard upgraded, this catalog needs to be added.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (DERBY-3191) SQL roles: add upgrade support

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dag H. Wanvik closed DERBY-3191.
--------------------------------


> SQL roles: add upgrade support
> ------------------------------
>
>                 Key: DERBY-3191
>                 URL: https://issues.apache.org/jira/browse/DERBY-3191
>             Project: Derby
>          Issue Type: Improvement
>          Components: Security, SQL
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>             Fix For: 10.4.1.3
>
>         Attachments: DERBY-3191.diff, DERBY-3191.stat, DERBY-3191b.diff, DERBY-3191b.stat
>
>
> Derby roles introduce a new system catalog (SYSROLES). When a database
> is hard upgraded, this catalog needs to be added.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (DERBY-3191) SQL roles: add upgrade support

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dag H. Wanvik resolved DERBY-3191.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 10.4.0.0

Committed DERBY-3191b as svn 597409, resolving.


> SQL roles: add upgrade support
> ------------------------------
>
>                 Key: DERBY-3191
>                 URL: https://issues.apache.org/jira/browse/DERBY-3191
>             Project: Derby
>          Issue Type: Improvement
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>             Fix For: 10.4.0.0
>
>         Attachments: DERBY-3191.diff, DERBY-3191.stat, DERBY-3191b.diff, DERBY-3191b.stat
>
>
> Derby roles introduce a new system catalog (SYSROLES). When a database
> is hard upgraded, this catalog needs to be added.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-3191) SQL roles: add upgrade support

Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544153 ] 

Dag H. Wanvik commented on DERBY-3191:
--------------------------------------

I definitely agree. I will post a new patch. Thanks, Rick!

> SQL roles: add upgrade support
> ------------------------------
>
>                 Key: DERBY-3191
>                 URL: https://issues.apache.org/jira/browse/DERBY-3191
>             Project: Derby
>          Issue Type: Improvement
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>         Attachments: DERBY-3191.diff, DERBY-3191.stat
>
>
> Derby roles introduce a new system catalog (SYSROLES). When a database
> is hard upgraded, this catalog needs to be added.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.