You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicecomb.apache.org by Willem Jiang <wi...@gmail.com> on 2018/02/24 08:47:13 UTC
Clean up the old saga modules
Hi team,
As we are planning the servicecomb-saga binary release[1], I found out
there are some old saga modules in the current master branch need to be
archived.
My proposal is we create a branch which holds current master branch codes
and remove the old saga module from the master branch. After that, we just
put the pack modules into the binary release of servicecomb-saga.
Any thoughts？
[1] https://issues.apache.org/jira/browse/SCB-346
Willem Jiang
Blog: http://willemjiang.blogspot.com (English)
http://jnn.iteye.com (Chinese)
Twitter: willemjiang
Weibo: 姜宁willem
Re: Clean up the old saga modules
Posted by Yang Bo <oa...@gmail.com>.
Seems everyone is OK with deleting the legacy code.
I'll include those changes as part of the m1 release.
On Mon, Feb 26, 2018 at 8:08 PM, Willem Jiang <wi...@gmail.com>
wrote:
> I think it depends on the user requirement.
> we can keep the old code there, if the user want to use it , we can put it
> back.
>
> On 2/26/18, Zheng Feng <zh...@gmail.com> wrote:
> > It looks good. Do we want to support the old saga module in the future ?
> >
> > 2018-02-24 16:47 GMT+08:00 Willem Jiang <wi...@gmail.com>:
> >
> >> Hi team,
> >>
> >> As we are planning the servicecomb-saga binary release[1], I found out
> >> there are some old saga modules in the current master branch need to be
> >> archived.
> >>
> >> My proposal is we create a branch which holds current master branch
> codes
> >> and remove the old saga module from the master branch. After that, we
> >> just
> >> put the pack modules into the binary release of servicecomb-saga.
> >>
> >> Any thoughts？
> >>
> >> [1] https://issues.apache.org/jira/browse/SCB-346
> >>
> >> Willem Jiang
> >>
> >> Blog: http://willemjiang.blogspot.com (English)
> >> http://jnn.iteye.com (Chinese)
> >> Twitter: willemjiang
> >> Weibo: 姜宁willem
> >>
> >
>
>
> --
>
> Willem Jiang
>
> Blog: http://willemjiang.blogspot.com (English)
> http://jnn.iteye.com (Chinese)
> Twitter: willemjiang
> Weibo: 姜宁willem
>
--
Best Regards,
Yang.
Re: Clean up the old saga modules
Posted by Willem Jiang <wi...@gmail.com>.
I think it depends on the user requirement.
we can keep the old code there, if the user want to use it , we can put it back.
On 2/26/18, Zheng Feng <zh...@gmail.com> wrote:
> It looks good. Do we want to support the old saga module in the future ?
>
> 2018-02-24 16:47 GMT+08:00 Willem Jiang <wi...@gmail.com>:
>
>> Hi team,
>>
>> As we are planning the servicecomb-saga binary release[1], I found out
>> there are some old saga modules in the current master branch need to be
>> archived.
>>
>> My proposal is we create a branch which holds current master branch codes
>> and remove the old saga module from the master branch. After that, we
>> just
>> put the pack modules into the binary release of servicecomb-saga.
>>
>> Any thoughts？
>>
>> [1] https://issues.apache.org/jira/browse/SCB-346
>>
>> Willem Jiang
>>
>> Blog: http://willemjiang.blogspot.com (English)
>> http://jnn.iteye.com (Chinese)
>> Twitter: willemjiang
>> Weibo: 姜宁willem
>>
>
--
Willem Jiang
Blog: http://willemjiang.blogspot.com (English)
http://jnn.iteye.com (Chinese)
Twitter: willemjiang
Weibo: 姜宁willem
Re: Clean up the old saga modules
Posted by Zheng Feng <zh...@gmail.com>.
It looks good. Do we want to support the old saga module in the future ?
2018-02-24 16:47 GMT+08:00 Willem Jiang <wi...@gmail.com>:
> Hi team,
>
> As we are planning the servicecomb-saga binary release[1], I found out
> there are some old saga modules in the current master branch need to be
> archived.
>
> My proposal is we create a branch which holds current master branch codes
> and remove the old saga module from the master branch. After that, we just
> put the pack modules into the binary release of servicecomb-saga.
>
> Any thoughts？
>
> [1] https://issues.apache.org/jira/browse/SCB-346
>
> Willem Jiang
>
> Blog: http://willemjiang.blogspot.com (English)
> http://jnn.iteye.com (Chinese)
> Twitter: willemjiang
> Weibo: 姜宁willem
>