You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "Jark Wu (Jira)" <ji...@apache.org> on 2020/05/22 14:24:00 UTC

[jira] [Commented] (FLINK-17884) package the codegen directory to flink-sql-parser jar

    [ https://issues.apache.org/jira/browse/FLINK-17884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17114081#comment-17114081 ] 

Jark Wu commented on FLINK-17884:
---------------------------------

Sounds like a good idea to me. Maybe we should add this: https://github.com/apache/calcite/blob/branch-1.19/core/pom.xml#L419

cc [~danny0405]

> package the codegen directory to flink-sql-parser jar
> -----------------------------------------------------
>
>                 Key: FLINK-17884
>                 URL: https://issues.apache.org/jira/browse/FLINK-17884
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table SQL / Planner
>    Affects Versions: 1.10.0
>            Reporter: zhanghang-dev
>            Priority: Minor
>
> Now extending flink sql requires manually copying Parser.tdd, includes/*.ftl and config.fmpp, so every time flink upgrades, you may need to copy these files again.If you can package codegen like calcite-core.jar. In this way, every time Flink upgrades, you only need to modify the version.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)