You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stdcxx.apache.org by Liviu Nicoara <ni...@hates.ms> on 2012/08/31 14:40:45 UTC
STDCXX forks
Please correct me if I am wrong.
I have seen two forks on github, one belonging to C. Bergstrom/Pathscale and the other to Stefan Teleman.
The first one contains a number of genuine code changes outside the Apache repository, but without canonical and meaningful commit comments, and without accompanying test cases. Some carry what seem to be bug id's from a private bug database. Some of the changes, e.g., 84d01405124b8c08bb43fdc3755ada2592449727, fa9a45fb36e45b71ba6b4ae93b50bd6679549420, seem odd. Are you guys dropping support for any platforms?
Stefan's seem like a complete git-ification of the whole Apache repository but with no changes I could detect.
Thanks.
L
Re: STDCXX forks
Posted by Wojciech Meyer <wo...@googlemail.com>.
Jim Jagielski <ji...@jaguNET.com> writes:
> On Aug 31, 2012, at 8:40 AM, Liviu Nicoara <ni...@hates.ms> wrote:
>
>>
>> Stefan's seem like a complete git-ification of the whole Apache repository but with no changes I could detect.
>>
>
> FWIW, The ASF supports git so if people think it would help,
> all we'd need to do is ask #infra to move stdcxx to git.
Git sounds much better to me, so I vote for it.
--
Wojciech Meyer
http://danmey.org
Re: STDCXX forks
Posted by Jim Jagielski <ji...@jaguNET.com>.
On Aug 31, 2012, at 8:40 AM, Liviu Nicoara <ni...@hates.ms> wrote:
>
> Stefan's seem like a complete git-ification of the whole Apache repository but with no changes I could detect.
>
FWIW, The ASF supports git so if people think it would help,
all we'd need to do is ask #infra to move stdcxx to git.
Re: STDCXX forks
Posted by Stefan Teleman <st...@gmail.com>.
On Fri, Aug 31, 2012 at 8:58 AM, "C. Bergström"
<cb...@pathscale.com> wrote:
> He has quite a number of patches and forget where those are kept. I'm
> guessing a lot of his fixes target KDE/Qt apps and the Perennial C++VS
> testsuite.
> http://www.peren.com/pages/cppvs_set.htm
Correction: my patches aren't related to Qt/KDE at all at this point -
they are related to Solaris. Apache stdcxx is part of Solaris Core.
So the "authoritative" patchset for Solaris/stdcxx is the one
publisehd by Oracle, since it is kept up-to-date and it represents an
officially released and supported version of stdcxx.
--Stefan
--
Stefan Teleman
KDE e.V.
stefan.teleman@gmail.com
Re: STDCXX forks
Posted by Liviu Nicoara <ni...@hates.ms>.
On 08/31/12 08:58, "C. Bergström" wrote:
> On 08/31/12 07:40 PM, Liviu Nicoara wrote:
>> Please correct me if I am wrong.
>>
>> I have seen two forks on github, one belonging to C. Bergstrom/Pathscale and the other to Stefan Teleman.
>>
>> The first one contains a number of genuine code changes outside the Apache repository, but without canonical and meaningful commit comments, and without accompanying test cases.
> We can help clean this up if it makes a real difference
>> Some carry what seem to be bug id's from a private bug database. Some of the changes, e.g., 84d01405124b8c08bb43fdc3755ada2592449727
> iirc we renamed the files because of some problem with cmake - it was trying to compile those files instead of treating them like headers.
>> , fa9a45fb36e45b71ba6b4ae93b50bd6679549420, seem odd.
> I forget why we did this tbh - I'll try to get an answer in case it comes up again as a question
>> Are you guys dropping support for any platforms?
> Not intentionally - We are using/testing this on Solaris, FBSD and Linux - We may add OSX/Win to that list soon, but I can't promise at this point. For targets we only are able to test x86 and x86_64
Hi Christopher,
I finished looking though the github changes. If you are interested in contributing some of those changes back, as complete patches [1], I would volunteer my time to promptly review them and work with you to get them in, as needed.
In the meantime, if you will, could you please elaborate on the two changes mentioned above? The first one changes the traditional file extension on the template implementation files, the second affects the library building on platforms like I mentioned in another post. AFAIK STDCXX does not implement or follow Boost conventions and/or library file structure.
HTH.
Thanks!
Liviu
[1] http://stdcxx.apache.org/bugs.html#patch_format
Re: STDCXX forks
Posted by "C. Bergström" <cb...@pathscale.com>.
On 08/31/12 08:10 PM, Liviu Nicoara wrote:
>
>>
>> NetBSD also has a "fork" I believe, but not sure if it's public/status
>
> Do you know where that is?
He just posted his bulk patch
http://www.netbsd.org/~joerg/stdcxx.diff
There's a small amount of CVS noise and we already have one part on our
github. I don't have more information
Re: STDCXX forks
Posted by Liviu Nicoara <ni...@hates.ms>.
On 08/31/12 08:58, "C. Bergström" wrote:
> On 08/31/12 07:40 PM, Liviu Nicoara wrote:
>> Please correct me if I am wrong.
>>
>> I have seen two forks on github, one belonging to C. Bergstrom/Pathscale and the other to Stefan Teleman.
>>
>> The first one contains a number of genuine code changes outside the Apache repository, but without canonical and meaningful commit comments, and without accompanying test cases.
> We can help clean this up if it makes a real difference
That is appreciated. It would make a huge difference to anybody coming anew to the project or just catching up, like me.
>> Some carry what seem to be bug id's from a private bug database. Some of the changes, e.g., 84d01405124b8c08bb43fdc3755ada2592449727
> iirc we renamed the files because of some problem with cmake - it was trying to compile those files instead of treating them like headers.
>> , fa9a45fb36e45b71ba6b4ae93b50bd6679549420, seem odd.
> I forget why we did this tbh - I'll try to get an answer in case it comes up again as a question
My point exactly, a good comment explains the why's.
>> Are you guys dropping support for any platforms?
> Not intentionally - We are using/testing this on Solaris, FBSD and Linux - We may add OSX/Win to that list soon, but I can't promise at this point. For targets we only are able to test x86 and x86_64
The reason I am asking is that changes to the template implementation files have most likely broken the support for compilers that do "implicit inclusion" of template implementations (a.k.a. link-time instantiation of templates). I am not incriminating anyone mind you, I am just trying to point out there mightbe a gap in your testing of your changes.
>
> NetBSD also has a "fork" I believe, but not sure if it's public/status
Do you know where that is?
>>
>> Stefan's seem like a complete git-ification of the whole Apache repository but with no changes I could detect.
> He has quite a number of patches and forget where those are kept. I'm guessing a lot of his fixes target KDE/Qt apps and the Perennial C++VS testsuite.
> http://www.peren.com/pages/cppvs_set.htm
>
I briefly looked over some patches, there's quite a few of them. I plan to go in more detail over the week-end.
Cheers.
L
Re: STDCXX forks
Posted by "C. Bergström" <cb...@pathscale.com>.
On 08/31/12 07:40 PM, Liviu Nicoara wrote:
> Please correct me if I am wrong.
>
> I have seen two forks on github, one belonging to C.
> Bergstrom/Pathscale and the other to Stefan Teleman.
>
> The first one contains a number of genuine code changes outside the
> Apache repository, but without canonical and meaningful commit
> comments, and without accompanying test cases.
We can help clean this up if it makes a real difference
> Some carry what seem to be bug id's from a private bug database. Some
> of the changes, e.g., 84d01405124b8c08bb43fdc3755ada2592449727
iirc we renamed the files because of some problem with cmake - it was
trying to compile those files instead of treating them like headers.
> , fa9a45fb36e45b71ba6b4ae93b50bd6679549420, seem odd.
I forget why we did this tbh - I'll try to get an answer in case it
comes up again as a question
> Are you guys dropping support for any platforms?
Not intentionally - We are using/testing this on Solaris, FBSD and Linux
- We may add OSX/Win to that list soon, but I can't promise at this
point. For targets we only are able to test x86 and x86_64
NetBSD also has a "fork" I believe, but not sure if it's public/status
>
> Stefan's seem like a complete git-ification of the whole Apache
> repository but with no changes I could detect.
He has quite a number of patches and forget where those are kept. I'm
guessing a lot of his fixes target KDE/Qt apps and the Perennial C++VS
testsuite.
http://www.peren.com/pages/cppvs_set.htm
Re: STDCXX forks
Posted by Liviu Nicoara <ni...@hates.ms>.
On Sep 1, 2012, at 1:52 PM, Stefan Teleman wrote:
> On Sat, Sep 1, 2012 at 12:15 PM, Liviu Nicoara <ni...@hates.ms> wrote:
>> [...]
>> This pretty much sums up my first impression.
>
> [...]
> To begin with: the compiler flags/GNUmakefile changes are very
> specific to the SunPro compilers and to our internal build system.
> These changes are most likely not suitable for inclusion in the
> canonical stdcxx, except maybe for the sunpro.config changes, in case
> someone would like to be able to replicate our builds. I'd like to
> mention that, in Solaris, Apache stdcxx is a "system library".
Good point.
>
> About the Standard C Library forwarding header files: these changes
> are specfic to Solaris. The reason behind them is: the Solaris
> architectural rules, which can be best summarized as: "there can be
> only one of each". In other words, it is Verboten, in Solaris, to
> duplicate the Standard C Library header files (or any other header
> file for that matter). The Solaris Standard C Library header files are
> C++-clean - they are required to be so, by the same architectural
> rules. Again, these changes are specific to Solaris, and are probably
> not portable across other implementations. I know for a fact that they
> are not portable for either the GCC or Intel compilers (with which I
> test regularly on Linux, in addition to SunPro).
>
> So these two groups of changesets can be ignored.
Got it.
>
> I opened yesterday STDCXX-1066:
>
> https://issues.apache.org/jira/browse/STDCXX-1056
>
> about the pthread_mutex_t/pthread_cond_t alignment on SPARCV8. I'll
> have patches done this weekend. Achtung: the patchset is very large
> and touches a very large number of files. It's strange that I didn't
> get an email about STDCXX-1066.
Acknowledged. I have seen the individual patches on those two websites.
>
> I'd also like to talk about STDCXX-1056:
>
> https://issues.apache.org/jira/browse/STDCXX-1056
>
> which has already had an initial discussion, and for which I have
> attached a patch. This issue also addresses (indirectly) linkage when
> building with GCC. On the recent versions of GCC that I have tested
> with, passing -supc++ on link line automatically links with the GNU
> libstdc++6.so (on top of linking with stdcxx), and that just bad.
I briefly looked at it, will delve into it later.
>
> And then I'll have to cross reference the patches which refer to our
> internal bug numbers because most of them are quite old and right now,
> off the top of my head, I can't remember what they are. :-)
Thanks!
Liviu
Re: STDCXX forks
Posted by Stefan Teleman <st...@gmail.com>.
On Sat, Sep 1, 2012 at 12:15 PM, Liviu Nicoara <ni...@hates.ms> wrote:
> Hi Stefan, I have went through the patches. Specifically, I have spent more
> time looking in the mutex alignment changes and the C++ C library headers
> patches, and I only read the others. In order:
>
> The test extensions seem to be genuine by and large, but I would further
> analyze them after I find out what is it they are addressing (test cases?).
>
> The regression tests whose names contain references to internal bug numbers
> require a bit more analysis as to their usefulness. Of course an explanation
> attached to each would alleviate duplicating your work. I have not
> cross-checked them to JIRA.
>
> Some of the compiler characterizations changes, as well as the associated
> GNUmakefile's, seem to be specific to your port, e.g., GNUmakefile,
> GNUmakefile.cfg changes. I may have spotted other issues but I would wait
> for your feed-back first.
>
> The C++ C library headers seem to have been re-written to your port. I am
> unsure why you needed this, but it surely breaks the original intent for
> these headers' structure. I have also noticed that you stripped the Apache
> notice and added an Oracle copyright notice on them.
>
> This pretty much sums up my first impression.
Hi
Yes, you are correct. :-)
To begin with: the compiler flags/GNUmakefile changes are very
specific to the SunPro compilers and to our internal build system.
These changes are most likely not suitable for inclusion in the
canonical stdcxx, except maybe for the sunpro.config changes, in case
someone would like to be able to replicate our builds. I'd like to
mention that, in Solaris, Apache stdcxx is a "system library".
About the Standard C Library forwarding header files: these changes
are specfic to Solaris. The reason behind them is: the Solaris
architectural rules, which can be best summarized as: "there can be
only one of each". In other words, it is Verboten, in Solaris, to
duplicate the Standard C Library header files (or any other header
file for that matter). The Solaris Standard C Library header files are
C++-clean - they are required to be so, by the same architectural
rules. Again, these changes are specific to Solaris, and are probably
not portable across other implementations. I know for a fact that they
are not portable for either the GCC or Intel compilers (with which I
test regularly on Linux, in addition to SunPro).
So these two groups of changesets can be ignored.
I opened yesterday STDCXX-1066:
https://issues.apache.org/jira/browse/STDCXX-1056
about the pthread_mutex_t/pthread_cond_t alignment on SPARCV8. I'll
have patches done this weekend. Achtung: the patchset is very large
and touches a very large number of files. It's strange that I didn't
get an email about STDCXX-1066.
I'd also like to talk about STDCXX-1056:
https://issues.apache.org/jira/browse/STDCXX-1056
which has already had an initial discussion, and for which I have
attached a patch. This issue also addresses (indirectly) linkage when
building with GCC. On the recent versions of GCC that I have tested
with, passing -supc++ on link line automatically links with the GNU
libstdc++6.so (on top of linking with stdcxx), and that just bad.
And then I'll have to cross reference the patches which refer to our
internal bug numbers because most of them are quite old and right now,
off the top of my head, I can't remember what they are. :-)
--Stefan
--
Stefan Teleman
KDE e.V.
stefan.teleman@gmail.com
Re: STDCXX forks
Posted by Liviu Nicoara <ni...@hates.ms>.
On 08/31/12 12:20, Stefan Teleman wrote:
> On Fri, Aug 31, 2012 at 8:40 AM, Liviu Nicoara <ni...@hates.ms> wrote:
>
>> Stefan's seem like a complete git-ification of the whole Apache repository
>> but with no changes I could detect.
>
> Not quite. :-)
> [...]
> The official Oracle port for Solaris 10 and 11, which I maintain, is here:
>
> http://src.opensolaris.org/source/xref/userland/gate/components/stdcxx/
Hi Stefan, I have went through the patches. Specifically, I have spent more time looking in the mutex alignment changes and the C++ C library headers patches, and I only read the others. In order:
The test extensions seem to be genuine by and large, but I would further analyze them after I find out what is it they are addressing (test cases?).
The regression tests whose names contain references to internal bug numbers require a bit more analysis as to their usefulness. Of course an explanation attached to each would alleviate duplicating your work. I have not cross-checked them to JIRA.
Some of the compiler characterizations changes, as well as the associated GNUmakefile's, seem to be specific to your port, e.g., GNUmakefile, GNUmakefile.cfg changes. I may have spotted other issues but I would wait for your feed-back first.
The C++ C library headers seem to have been re-written to your port. I am unsure why you needed this, but it surely breaks the original intent for these headers' structure. I have also noticed that you stripped the Apache notice and added an Oracle copyright notice on them.
This pretty much sums up my first impression.
If you were willing to submit them one by one (*), complete with test cases and complete patches (ChangeLog entries and all) I would put in the necessary review time and provide feed-back asap. Please let me know if I missed anything.
I sincerely hope this helps.
Thanks!
Liviu
(*) As in issue by issue, not file by file.
Re: STDCXX forks
Posted by Liviu Nicoara <ni...@hates.ms>.
On 08/31/12 12:20, Stefan Teleman wrote:
> On Fri, Aug 31, 2012 at 8:40 AM, Liviu Nicoara<ni...@hates.ms> wrote:
>
>> Stefan's seem like a complete git-ification of the whole Apache repository
>> but with no changes I could detect.
>
> Not quite. :-)
I stand corrected. Thanks!
>
> You are - most likely referring to the svn repo at CVSDude here:
>
> http://kdesolaris-svn.cvsdude.com/trunk/STDCXX/4.2.1/
>
> Yes I maintain that "fork". All the patches are in this directory:
>
> http://kdesolaris-svn.cvsdude.com/trunk/STDCXX/4.2.1/Solaris/diffs/
>
> and they apply with the apply_patches.sh script from here:
>
> http://kdesolaris-svn.cvsdude.com/trunk/STDCXX/4.2.1/Solaris/apply_patches.sh
>
> The official Oracle port for Solaris 10 and 11, which I maintain, is here:
>
> http://src.opensolaris.org/source/xref/userland/gate/components/stdcxx/
>
> This is the source code which is used to build stdcxx on Solaris 10
> and 11. The patches for stdcxx on Solaris are here:
>
> http://src.opensolaris.org/source/xref/userland/gate/components/stdcxx/patches/
>
> The official Solaris 11 stdcxx package can be installed on Solaris 11 from here:
>
> http://pkg.oracle.com/solaris/release/en/search.shtml?token=stdcxx&action=Search
>
> For Solaris 10, you need to install SUNWlibstdcxx4 - which contains
> the stdcxx library and its header files - and SUNWlibstdcxx4S which
> contains the source code plus all the patches, and which installs in
> /usr/share/src/. It installs on Solaris 10 Update 10 and later.
>
> I maintain the repo at cvsdude on an ad-hoc basis. That means now and then. :-)
>
> The source code repo at Oracle is constantly maintained at Oracle, and
> we publish source code drops every two weeks there (I think).
>
> --Stefan
>
--
And now I see with eye serene
The very pulse of the machine.
Re: STDCXX forks
Posted by Stefan Teleman <st...@gmail.com>.
On Fri, Aug 31, 2012 at 8:40 AM, Liviu Nicoara <ni...@hates.ms> wrote:
> Stefan's seem like a complete git-ification of the whole Apache repository
> but with no changes I could detect.
Not quite. :-)
You are - most likely referring to the svn repo at CVSDude here:
http://kdesolaris-svn.cvsdude.com/trunk/STDCXX/4.2.1/
Yes I maintain that "fork". All the patches are in this directory:
http://kdesolaris-svn.cvsdude.com/trunk/STDCXX/4.2.1/Solaris/diffs/
and they apply with the apply_patches.sh script from here:
http://kdesolaris-svn.cvsdude.com/trunk/STDCXX/4.2.1/Solaris/apply_patches.sh
The official Oracle port for Solaris 10 and 11, which I maintain, is here:
http://src.opensolaris.org/source/xref/userland/gate/components/stdcxx/
This is the source code which is used to build stdcxx on Solaris 10
and 11. The patches for stdcxx on Solaris are here:
http://src.opensolaris.org/source/xref/userland/gate/components/stdcxx/patches/
The official Solaris 11 stdcxx package can be installed on Solaris 11 from here:
http://pkg.oracle.com/solaris/release/en/search.shtml?token=stdcxx&action=Search
For Solaris 10, you need to install SUNWlibstdcxx4 - which contains
the stdcxx library and its header files - and SUNWlibstdcxx4S which
contains the source code plus all the patches, and which installs in
/usr/share/src/. It installs on Solaris 10 Update 10 and later.
I maintain the repo at cvsdude on an ad-hoc basis. That means now and then. :-)
The source code repo at Oracle is constantly maintained at Oracle, and
we publish source code drops every two weeks there (I think).
--Stefan
--
Stefan Teleman
KDE e.V.
stefan.teleman@gmail.com