[GitHub] keith-turner commented on a change in pull request #960: Use NewTableConfiguration (and also trivial code cleanup)

[GitBox <gi...@apache.org>]

keith-turner commented on a change in pull request #960: Use NewTableConfiguration (and also trivial code cleanup)
URL: https://github.com/apache/fluo/pull/960#discussion_r147242859
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/fluo/core/client/FluoAdminImpl.java
 ##########
 @@ -221,23 +225,46 @@ private void initialize(Connector conn) throws Exception {
         CuratorUtil.NodeExistsPolicy.FAIL);
     CuratorUtil.putData(curator, ZookeeperPath.ORACLE_GC_TIMESTAMP, new byte[] {'0'},
         CuratorUtil.NodeExistsPolicy.FAIL);
+  }
 
-    conn.tableOperations().create(config.getAccumuloTable(), false);
-    Map<String, Set<Text>> groups = new HashMap<>();
-    groups.put("notify", Collections.singleton(ByteUtil.toText(ColumnConstants.NOTIFY_CF)));
-    conn.tableOperations().setLocalityGroups(config.getAccumuloTable(), groups);
-
-    IteratorSetting gcIter = new IteratorSetting(10, "gc", GarbageCollectionIterator.class);
-    GarbageCollectionIterator.setZookeepers(gcIter, config.getAppZookeepers());
+  private String encodeColumnFamily(Bytes cf) {
 
 Review comment:
   I think this code was copied from Accumulo?  We should open issues in Accumulo to improve the ability to set iterators and locality groups on new table config.  I'll open those issues.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services