You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by gatorsmile <gi...@git.apache.org> on 2017/12/06 18:08:20 UTC

[GitHub] spark pull request #19913: [SPARK-22720] [SS] Make EventTimeWatermark UnaryN...

GitHub user gatorsmile opened a pull request:

    https://github.com/apache/spark/pull/19913

    [SPARK-22720] [SS] Make EventTimeWatermark UnaryNode

    ## What changes were proposed in this pull request?
    Our Analyzer and Optimizer has multiple rules for `UnaryNode`. After making `EventTimeWatermark` extend `UnaryNode`, we do not need a special handling for `EventTimeWatermark`.
    
    ## How was this patch tested?
    The existing tests

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gatorsmile/spark eventtimewatermark

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/19913.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19913
    
----
commit 2ce27df7324c0763170cb492b7581863a314454d
Author: gatorsmile <ga...@gmail.com>
Date:   2017-12-06T18:00:11Z

    fix

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19913: [SPARK-22720] [SS] Make EventTimeWatermark Extend UnaryN...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19913
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84567/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #19913: [SPARK-22720] [SS] Make EventTimeWatermark Extend...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/19913


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19913: [SPARK-22720] [SS] Make EventTimeWatermark Extend UnaryN...

Posted by gatorsmile <gi...@git.apache.org>.

Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/19913
  
    Thanks! Merged to master.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19913: [SPARK-22720] [SS] Make EventTimeWatermark Extend UnaryN...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19913
  
    **[Test build #84567 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84567/testReport)** for PR 19913 at commit [`2ce27df`](https://github.com/apache/spark/commit/2ce27df7324c0763170cb492b7581863a314454d).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19913: [SPARK-22720] [SS] Make EventTimeWatermark Extend UnaryN...

Posted by zsxwing <gi...@git.apache.org>.

Github user zsxwing commented on the issue:

    https://github.com/apache/spark/pull/19913
  
    LGTM


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19913: [SPARK-22720] [SS] Make EventTimeWatermark Extend UnaryN...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19913
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19913: [SPARK-22720] [SS] Make EventTimeWatermark Extend UnaryN...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19913
  
    **[Test build #84567 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84567/testReport)** for PR 19913 at commit [`2ce27df`](https://github.com/apache/spark/commit/2ce27df7324c0763170cb492b7581863a314454d).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org