You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Jonathan Moore (JIRA)" <ji...@apache.org> on 2010/07/12 23:42:49 UTC
[jira] Created: (HTTPCLIENT-967) allow cache to be configured as a
non-shared (private) cache
allow cache to be configured as a non-shared (private) cache
------------------------------------------------------------
Key: HTTPCLIENT-967
URL: https://issues.apache.org/jira/browse/HTTPCLIENT-967
Project: HttpComponents HttpClient
Issue Type: Improvement
Components: Cache
Affects Versions: 4.1 Alpha2
Reporter: Jonathan Moore
Currently the CachingHttpClient only behaves as a shared cache, which is a safe and conservative assumption. However, in some settings, it would be appropriate to be able to configure the CachingHttpClient as a non-shared cache, which would make more responses cacheable, including:
* responses to requests with Authorization headers
* responses with 'Cache-Control: private'
* ability to serve stale responses when invalidation fails for 'Cache-Control: proxy-revalidate'
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Updated: (HTTPCLIENT-967) allow cache to be configured as a
non-shared (private) cache
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oleg Kalnichevski updated HTTPCLIENT-967:
-----------------------------------------
Fix Version/s: 4.1 Alpha3
(was: Future)
> allow cache to be configured as a non-shared (private) cache
> ------------------------------------------------------------
>
> Key: HTTPCLIENT-967
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-967
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: Cache
> Affects Versions: 4.1 Alpha2
> Reporter: Jonathan Moore
> Fix For: 4.1 Alpha3
>
> Attachments: nonshared-cache-2.patch, nonshared-cache.patch
>
>
> Currently the CachingHttpClient only behaves as a shared cache, which is a safe and conservative assumption. However, in some settings, it would be appropriate to be able to configure the CachingHttpClient as a non-shared cache, which would make more responses cacheable, including:
> * responses to requests with Authorization headers
> * responses with 'Cache-Control: private'
> * ability to serve stale responses when invalidation fails for 'Cache-Control: proxy-revalidate'
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Commented: (HTTPCLIENT-967) allow cache to be configured as
a non-shared (private) cache
Posted by "Jonathan Moore (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12893228#action_12893228 ]
Jonathan Moore commented on HTTPCLIENT-967:
-------------------------------------------
Sorry, just found a minor problem with my patch, will resubmit shortly.
> allow cache to be configured as a non-shared (private) cache
> ------------------------------------------------------------
>
> Key: HTTPCLIENT-967
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-967
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: Cache
> Affects Versions: 4.1 Alpha2
> Reporter: Jonathan Moore
> Fix For: Future
>
> Attachments: nonshared-cache.patch
>
>
> Currently the CachingHttpClient only behaves as a shared cache, which is a safe and conservative assumption. However, in some settings, it would be appropriate to be able to configure the CachingHttpClient as a non-shared cache, which would make more responses cacheable, including:
> * responses to requests with Authorization headers
> * responses with 'Cache-Control: private'
> * ability to serve stale responses when invalidation fails for 'Cache-Control: proxy-revalidate'
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Updated: (HTTPCLIENT-967) allow cache to be configured as a
non-shared (private) cache
Posted by "Jonathan Moore (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Moore updated HTTPCLIENT-967:
--------------------------------------
Attachment: nonshared-cache-2.patch
This is a corrected patch that makes AbstractProtocolTest an abstract class (maven was trying to run it as a test case). That's the only difference between this patch and the previous one.
This patch is contributed to the ASF with the permission of my employer.
> allow cache to be configured as a non-shared (private) cache
> ------------------------------------------------------------
>
> Key: HTTPCLIENT-967
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-967
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: Cache
> Affects Versions: 4.1 Alpha2
> Reporter: Jonathan Moore
> Fix For: Future
>
> Attachments: nonshared-cache-2.patch, nonshared-cache.patch
>
>
> Currently the CachingHttpClient only behaves as a shared cache, which is a safe and conservative assumption. However, in some settings, it would be appropriate to be able to configure the CachingHttpClient as a non-shared cache, which would make more responses cacheable, including:
> * responses to requests with Authorization headers
> * responses with 'Cache-Control: private'
> * ability to serve stale responses when invalidation fails for 'Cache-Control: proxy-revalidate'
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Updated: (HTTPCLIENT-967) allow cache to be configured as a
non-shared (private) cache
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oleg Kalnichevski updated HTTPCLIENT-967:
-----------------------------------------
Fix Version/s: Future
> allow cache to be configured as a non-shared (private) cache
> ------------------------------------------------------------
>
> Key: HTTPCLIENT-967
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-967
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: Cache
> Affects Versions: 4.1 Alpha2
> Reporter: Jonathan Moore
> Fix For: Future
>
>
> Currently the CachingHttpClient only behaves as a shared cache, which is a safe and conservative assumption. However, in some settings, it would be appropriate to be able to configure the CachingHttpClient as a non-shared cache, which would make more responses cacheable, including:
> * responses to requests with Authorization headers
> * responses with 'Cache-Control: private'
> * ability to serve stale responses when invalidation fails for 'Cache-Control: proxy-revalidate'
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Updated: (HTTPCLIENT-967) allow cache to be configured as a
non-shared (private) cache
Posted by "Jonathan Moore (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Moore updated HTTPCLIENT-967:
--------------------------------------
Attachment: nonshared-cache.patch
I have attached a patch to address this issue. Please note that this patch also includes the HttpParams-style configuration patch that was posted for issue 972:
https://issues.apache.org/jira/browse/HTTPCLIENT-972
(If you need me to rebuild this because you have already applied said patch for issue 972, I'm happy to do so).
Major changes in this patch are to extract an AbstractProtocolTest superclass from TestProtocolRequirements, so that we can inherit from this for a new test class, TestProtocolAllowedBehavior (i.e. things where the HTTP/1.1 spec says we MAY do something). All MUST requirements currently under test still pass, but now we cache responses for the items mentioned in this issue if we are a non-shared (private) cache.
This patch is contributed to the ASF with the permission of my employer.
> allow cache to be configured as a non-shared (private) cache
> ------------------------------------------------------------
>
> Key: HTTPCLIENT-967
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-967
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: Cache
> Affects Versions: 4.1 Alpha2
> Reporter: Jonathan Moore
> Fix For: Future
>
> Attachments: nonshared-cache.patch
>
>
> Currently the CachingHttpClient only behaves as a shared cache, which is a safe and conservative assumption. However, in some settings, it would be appropriate to be able to configure the CachingHttpClient as a non-shared cache, which would make more responses cacheable, including:
> * responses to requests with Authorization headers
> * responses with 'Cache-Control: private'
> * ability to serve stale responses when invalidation fails for 'Cache-Control: proxy-revalidate'
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Resolved: (HTTPCLIENT-967) allow cache to be configured as a
non-shared (private) cache
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oleg Kalnichevski resolved HTTPCLIENT-967.
------------------------------------------
Resolution: Fixed
Patch checked in.
Oleg
> allow cache to be configured as a non-shared (private) cache
> ------------------------------------------------------------
>
> Key: HTTPCLIENT-967
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-967
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: Cache
> Affects Versions: 4.1 Alpha2
> Reporter: Jonathan Moore
> Fix For: 4.1 Alpha3
>
> Attachments: nonshared-cache-2.patch, nonshared-cache-3.patch, nonshared-cache.patch
>
>
> Currently the CachingHttpClient only behaves as a shared cache, which is a safe and conservative assumption. However, in some settings, it would be appropriate to be able to configure the CachingHttpClient as a non-shared cache, which would make more responses cacheable, including:
> * responses to requests with Authorization headers
> * responses with 'Cache-Control: private'
> * ability to serve stale responses when invalidation fails for 'Cache-Control: proxy-revalidate'
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Updated: (HTTPCLIENT-967) allow cache to be configured as a
non-shared (private) cache
Posted by "Jonathan Moore (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Moore updated HTTPCLIENT-967:
--------------------------------------
Attachment: nonshared-cache-3.patch
Uploading a version of the patch compatible with the recent resolution of issue 972 (i.e. using the CacheConfig bean for configuration of the caching module).
This patch is contributed with the permission of my employer.
> allow cache to be configured as a non-shared (private) cache
> ------------------------------------------------------------
>
> Key: HTTPCLIENT-967
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-967
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: Cache
> Affects Versions: 4.1 Alpha2
> Reporter: Jonathan Moore
> Fix For: 4.1 Alpha3
>
> Attachments: nonshared-cache-2.patch, nonshared-cache-3.patch, nonshared-cache.patch
>
>
> Currently the CachingHttpClient only behaves as a shared cache, which is a safe and conservative assumption. However, in some settings, it would be appropriate to be able to configure the CachingHttpClient as a non-shared cache, which would make more responses cacheable, including:
> * responses to requests with Authorization headers
> * responses with 'Cache-Control: private'
> * ability to serve stale responses when invalidation fails for 'Cache-Control: proxy-revalidate'
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org