You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2021/01/22 18:40:07 UTC

[GitHub] [phoenix] ChinmaySKulkarni edited a comment on pull request #1105: PHOENIX-6250 Fix ViewMetadataIT test flapper (addendum)

ChinmaySKulkarni edited a comment on pull request #1105:
URL: https://github.com/apache/phoenix/pull/1105#issuecomment-765609975


   > @yanxinyi View's not getting deleted while parent was dropped has something to do with SYSTEM.TASK? Do we save some intermittent state while dropping view in SYSTEM.TASK?
   
   Yes we use the SYSTEM.TASK table for dropping child views asynchronously whenever a drop <parent table/view> cascade command is issued. By setting these configs, we are ensuring that the background TaskRegionObserver thread does not automatically pick up DropChildViewTasks (by never scheduling these tasks in the first place). This prevents race conditions in the test and makes it more deterministic since we already explicitly call runDropChildViewsTask() in the test wherever cascade drops are issued:
   https://github.com/apache/phoenix/blob/ba6ad70541d9dae88ab574df3889f5fe2c0ef7fa/phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewMetadataIT.java#L720-L726


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org