[jira] [Commented] (HADOOP-12045) Enable LocalFileSystem#setTimes to change atime

["zhihai xu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-12045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566991#comment-14566991 ] 

zhihai xu commented on HADOOP-12045:
------------------------------------

Hi [~fjk], Thanks for filing and working this issue.
One nit: Could you replace the following code with a function in {{testSetTimes}}? I saw these code is repeated multiple times in your patch.
{code}
    status = fileSys.getFileStatus(path);
    assertEquals(newModTime, status.getModificationTime());
    assertEquals(newAccTime, status.getAccessTime());
{code}

By the way, did you test the patch at window platform?
cc [~cnauroth] for window platform.

> Enable LocalFileSystem#setTimes to change atime
> -----------------------------------------------
>
>                 Key: HADOOP-12045
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12045
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>            Reporter: Kazuho Fujii
>            Priority: Minor
>         Attachments: HADOOP-12045.001.patch
>
>
> LocalFileSystem#setTimes method can not change the last access time currently.
> With java.nio.file package in Java 7, we can implement the function easily.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)