You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Zheng Shao (JIRA)" <ji...@apache.org> on 2009/04/21 11:14:47 UTC
[jira] Created: (HIVE-437) Allow both table.col and col.field in
the grammar
Allow both table.col and col.field in the grammar
-------------------------------------------------
Key: HIVE-437
URL: https://issues.apache.org/jira/browse/HIVE-437
Project: Hadoop Hive
Issue Type: Bug
Components: Query Processor
Affects Versions: 0.4.0
Reporter: Zheng Shao
Assignee: Zheng Shao
There is a bug in the grammar that only allows table.col but not col.field. We should allow both.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-437) Allow both table.col and col.field in
the grammar
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Shao updated HIVE-437:
----------------------------
Attachment: HIVE-437.3.patch
Added the comments in PartitionPruner.java as Namit suggested.
Yes, this only needs to go to trunk.
> Allow both table.col and col.field in the grammar
> -------------------------------------------------
>
> Key: HIVE-437
> URL: https://issues.apache.org/jira/browse/HIVE-437
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Affects Versions: 0.4.0
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Attachments: HIVE-437.1.code-only.patch, HIVE-437.1.patch, HIVE-437.2.code-only.patch, HIVE-437.2.patch, HIVE-437.3.patch
>
>
> There is a bug in the grammar that only allows table.col but not col.field. We should allow both.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-437) Allow both table.col and col.field in
the grammar
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-437:
----------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed. Thanks Zheng
> Allow both table.col and col.field in the grammar
> -------------------------------------------------
>
> Key: HIVE-437
> URL: https://issues.apache.org/jira/browse/HIVE-437
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Affects Versions: 0.4.0
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Attachments: HIVE-437.1.code-only.patch, HIVE-437.1.patch, HIVE-437.2.code-only.patch, HIVE-437.2.patch, HIVE-437.3.patch
>
>
> There is a bug in the grammar that only allows table.col but not col.field. We should allow both.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-437) Allow both table.col and col.field in
the grammar
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Shao updated HIVE-437:
----------------------------
Attachment: HIVE-437.1.patch
This patch fixes the problem. It also fixes the bug in PartitionPruner that fails with "WHERE ds = '2009-01-01'".
> Allow both table.col and col.field in the grammar
> -------------------------------------------------
>
> Key: HIVE-437
> URL: https://issues.apache.org/jira/browse/HIVE-437
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Affects Versions: 0.4.0
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Attachments: HIVE-437.1.patch
>
>
> There is a bug in the grammar that only allows table.col but not col.field. We should allow both.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-437) Allow both table.col and col.field in
the grammar
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-437:
--------------------------------
Fix Version/s: 0.4.0
Affects Version/s: (was: 0.4.0)
> Allow both table.col and col.field in the grammar
> -------------------------------------------------
>
> Key: HIVE-437
> URL: https://issues.apache.org/jira/browse/HIVE-437
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Fix For: 0.4.0
>
> Attachments: HIVE-437.1.code-only.patch, HIVE-437.1.patch, HIVE-437.2.code-only.patch, HIVE-437.2.patch, HIVE-437.3.patch
>
>
> There is a bug in the grammar that only allows table.col but not col.field. We should allow both.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-437) Allow both table.col and col.field in
the grammar
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Shao updated HIVE-437:
----------------------------
Status: Patch Available (was: Open)
> Allow both table.col and col.field in the grammar
> -------------------------------------------------
>
> Key: HIVE-437
> URL: https://issues.apache.org/jira/browse/HIVE-437
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Affects Versions: 0.4.0
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Attachments: HIVE-437.1.code-only.patch, HIVE-437.1.patch, HIVE-437.2.code-only.patch, HIVE-437.2.patch
>
>
> There is a bug in the grammar that only allows table.col but not col.field. We should allow both.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-437) Allow both table.col and col.field in
the grammar
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Shao updated HIVE-437:
----------------------------
Attachment: HIVE-437.2.patch
Passed all tests.
> Allow both table.col and col.field in the grammar
> -------------------------------------------------
>
> Key: HIVE-437
> URL: https://issues.apache.org/jira/browse/HIVE-437
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Affects Versions: 0.4.0
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Attachments: HIVE-437.1.code-only.patch, HIVE-437.1.patch, HIVE-437.2.code-only.patch, HIVE-437.2.patch
>
>
> There is a bug in the grammar that only allows table.col but not col.field. We should allow both.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-437) Allow both table.col and col.field in
the grammar
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12701682#action_12701682 ]
Namit Jain commented on HIVE-437:
---------------------------------
looks good.
PartitionPruner still uses old code - exprNodeTempDesc. Can you write a comment there saying that his is temporary and will be removed anyway
once PartitionPruner moves to the walker framework ?
I will commit it after that. Also, I dont think this needs to be merged to 0.3 - is that correct ?
> Allow both table.col and col.field in the grammar
> -------------------------------------------------
>
> Key: HIVE-437
> URL: https://issues.apache.org/jira/browse/HIVE-437
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Affects Versions: 0.4.0
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Attachments: HIVE-437.1.code-only.patch, HIVE-437.1.patch, HIVE-437.2.code-only.patch, HIVE-437.2.patch
>
>
> There is a bug in the grammar that only allows table.col but not col.field. We should allow both.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-437) Allow both table.col and col.field in
the grammar
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Shao updated HIVE-437:
----------------------------
Attachment: HIVE-437.1.code-only.patch
This one is the same as HIVE-437.1.patch, but it only contains code changes (NO test and result changes).
> Allow both table.col and col.field in the grammar
> -------------------------------------------------
>
> Key: HIVE-437
> URL: https://issues.apache.org/jira/browse/HIVE-437
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Affects Versions: 0.4.0
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Attachments: HIVE-437.1.code-only.patch, HIVE-437.1.patch
>
>
> There is a bug in the grammar that only allows table.col but not col.field. We should allow both.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-437) Allow both table.col and col.field in
the grammar
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Shao updated HIVE-437:
----------------------------
Attachment: HIVE-437.2.code-only.patch
Talked with the team offline and make some changes:
1. We will now output an error if an identifier in the expression can be both a table alias and a column.
2. The Expression GraphWalker's process will return NULL for a table name. Originally we were returning a String for table name, and exprNodeDesc for others, which is not good. I didn't change the PartitionPruner in the same direction, because we are going to refactor that code completely pretty soon.
> Allow both table.col and col.field in the grammar
> -------------------------------------------------
>
> Key: HIVE-437
> URL: https://issues.apache.org/jira/browse/HIVE-437
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Affects Versions: 0.4.0
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Attachments: HIVE-437.1.code-only.patch, HIVE-437.1.patch, HIVE-437.2.code-only.patch, HIVE-437.2.patch
>
>
> There is a bug in the grammar that only allows table.col but not col.field. We should allow both.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.