[GitHub] [airflow] ecerulm commented on a change in pull request #16678: WIP: Solve timezone serialization by adding a schedule_timezone parameter to DAG

[GitBox <gi...@apache.org>]

ecerulm commented on a change in pull request #16678:
URL: https://github.com/apache/airflow/pull/16678#discussion_r659855128



##########
File path: airflow/models/dag.py
##########
@@ -302,16 +304,20 @@ def __init__(
         self.fileloc = back.f_code.co_filename if back else ""
         self.task_dict: Dict[str, BaseOperator] = {}
 
-        # set timezone from start_date
+        # set timezone from schedule_timezone or start_date
+        if schedule_timezone:
+            self.schedule_timezone = self._get_tzname_or_offset(schedule_timezone)

Review comment:
       I don't think we really want to check that the `start_date` time zone matches the `schedule_timezone`.  That's why I wanted to introduce `schedule_timezone` to avoid having to rely on inferring things from `start_date.tzinfo`.
   
   There is no problem to specify the `start_date` in one timezone, the `end_date` in another timezone, and have yet another timezone for the `schedule_timezone`.  I can see people (myself included) using  iso 8601 string like `2021-06-01T12:00:00+01:00` for `start_date` and `schedule_timezone='Europe/Stockholm'` 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org