You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by Max Berger <ma...@berger.name> on 2008/02/12 17:55:45 UTC
Repository properties?
Dear Fop devs,
I'd like to make some property changes in svn:
On all java files:
- set svn:eol-style native
- set svn:keywords Author Date Id Revision
supply a .sh script "fixproperties.sh" in the root dir which does this
automatically (should be run from time to time)
On hyph
ignore *.xml
To be discussed:
on *xml
- set svn:eol-style native
Note that something similar has been discussed for xmlgraphics [1].
Please let me know if you see a problem.
[1] http://mail-archives.apache.org/mod_mbox/xmlgraphics-general/200707.mbox/%3c46A8B548.9070706@anyware-tech.com%3e
Max
Re: Repository properties?
Posted by Max Berger <ma...@berger.name>.
Vincent,
thanks for noticing. Seems like -or does not work as I would expect it
too. I've fixed it (commitig right now).
Max
2008/2/13, Vincent Hennebert <vi...@anyware-tech.com>:
> Hi Max,
>
> Thanks for doing that, although I'm afraid it's not enough. If the
> svn:eol-style wasn't set when a file was committed for the first time,
> then it's "too late". Indeed after your change I still have XML files
> that have spurious ^M at the end of some lines. They need to be fixed by
> hand and re-committed.
> Also, the script didn't modify java files, I think there are missing
> brackets.
> I'll try to take care of that in the next days.
>
> Cheers,
> Vincent
>
>
> Max Berger wrote:
> > Dear Fop-Devs,
> >
> > done.
> > After greping through the code I saw that "Id" is used in all java
> > files and "Revision" is used in many testcases, so I decided to use
> > these two. If you have further improments, please change the
> > fixsvnprops.sh file.
> >
> > Please update before your next changes, as this has touched almost every file.
> >
> > Max
> >
> > 2008/2/13, The Web Maestro <th...@gmail.com>:
> >> On Feb 12, 2008 12:59 PM, Jeremias Maerki <de...@jeremias-maerki.ch> wrote:
> >>> I agree with Andreas' comments. Go ahead.
> >> Makes sense to me.
> >>
> >> Regards,
> >>
> >> The Web Maestro
> >> --
> >> <th...@gmail.com> - <http://homepage.mac.com/webmaestro/>
> >> My religion is simple. My religion is kindness.
> >> - HH The 14th Dalai Lama of Tibet
> >>
>
> --
> Vincent Hennebert Anyware Technologies
> http://people.apache.org/~vhennebert http://www.anyware-tech.com
> Apache FOP Committer FOP Development/Consulting
>
Re: Repository properties?
Posted by Vincent Hennebert <vi...@anyware-tech.com>.
Hi Max,
Thanks for doing that, although I’m afraid it’s not enough. If the
svn:eol-style wasn’t set when a file was committed for the first time,
then it’s “too late”. Indeed after your change I still have XML files
that have spurious ^M at the end of some lines. They need to be fixed by
hand and re-committed.
Also, the script didn’t modify java files, I think there are missing
brackets.
I’ll try to take care of that in the next days.
Cheers,
Vincent
Max Berger wrote:
> Dear Fop-Devs,
>
> done.
> After greping through the code I saw that "Id" is used in all java
> files and "Revision" is used in many testcases, so I decided to use
> these two. If you have further improments, please change the
> fixsvnprops.sh file.
>
> Please update before your next changes, as this has touched almost every file.
>
> Max
>
> 2008/2/13, The Web Maestro <th...@gmail.com>:
>> On Feb 12, 2008 12:59 PM, Jeremias Maerki <de...@jeremias-maerki.ch> wrote:
>>> I agree with Andreas' comments. Go ahead.
>> Makes sense to me.
>>
>> Regards,
>>
>> The Web Maestro
>> --
>> <th...@gmail.com> - <http://homepage.mac.com/webmaestro/>
>> My religion is simple. My religion is kindness.
>> - HH The 14th Dalai Lama of Tibet
>>
--
Vincent Hennebert Anyware Technologies
http://people.apache.org/~vhennebert http://www.anyware-tech.com
Apache FOP Committer FOP Development/Consulting
Re: Repository properties?
Posted by Max Berger <ma...@berger.name>.
Dear Fop-Devs,
done.
After greping through the code I saw that "Id" is used in all java
files and "Revision" is used in many testcases, so I decided to use
these two. If you have further improments, please change the
fixsvnprops.sh file.
Please update before your next changes, as this has touched almost every file.
Max
2008/2/13, The Web Maestro <th...@gmail.com>:
> On Feb 12, 2008 12:59 PM, Jeremias Maerki <de...@jeremias-maerki.ch> wrote:
> > I agree with Andreas' comments. Go ahead.
>
> Makes sense to me.
>
> Regards,
>
> The Web Maestro
> --
> <th...@gmail.com> - <http://homepage.mac.com/webmaestro/>
> My religion is simple. My religion is kindness.
> - HH The 14th Dalai Lama of Tibet
>
Re: Repository properties?
Posted by The Web Maestro <th...@gmail.com>.
On Feb 12, 2008 12:59 PM, Jeremias Maerki <de...@jeremias-maerki.ch> wrote:
> I agree with Andreas' comments. Go ahead.
Makes sense to me.
Regards,
The Web Maestro
--
<th...@gmail.com> - <http://homepage.mac.com/webmaestro/>
My religion is simple. My religion is kindness.
- HH The 14th Dalai Lama of Tibet
Re: Repository properties?
Posted by Jeremias Maerki <de...@jeremias-maerki.ch>.
I agree with Andreas' comments. Go ahead.
On 12.02.2008 17:55:45 Max Berger wrote:
> Dear Fop devs,
>
> I'd like to make some property changes in svn:
>
> On all java files:
> - set svn:eol-style native
> - set svn:keywords Author Date Id Revision
>
> supply a .sh script "fixproperties.sh" in the root dir which does this
> automatically (should be run from time to time)
>
> On hyph
> ignore *.xml
>
> To be discussed:
> on *xml
> - set svn:eol-style native
>
> Note that something similar has been discussed for xmlgraphics [1].
>
> Please let me know if you see a problem.
>
> [1] http://mail-archives.apache.org/mod_mbox/xmlgraphics-general/200707.mbox/%3c46A8B548.9070706@anyware-tech.com%3e
>
> Max
Jeremias Maerki
Re: Repository properties?
Posted by Andreas Delmelle <an...@telenet.be>.
On Feb 12, 2008, at 17:55, Max Berger wrote:
> Dear Fop devs,
>
> I'd like to make some property changes in svn:
>
> On all java files:
> - set svn:eol-style native
This should ideally already be the case. At least, I know I have
configured SVN locally to force this (as do a lot of the committers,
IIC)
> - set svn:keywords Author Date Id Revision
Same for "Id". No strong opinion on the other keywords on my account.
>
> supply a .sh script "fixproperties.sh" in the root dir which does this
> automatically (should be run from time to time)
That seems like a good idea. OTOH, I'd rather stress on the site
somewhere that anyone who has commit-privileges configures his SVN
client so it becomes an automatism for every committer.
>
> On hyph
> ignore *.xml
>
> To be discussed:
> on *xml
> - set svn:eol-style native
I also set this for the fotree- and layoutengine-testcases (I think;
will check and confirm)
In general: +1
Cheers
Andreas