You are viewing a plain text version of this content. The canonical link for it is here.
Posted to taglibs-dev@jakarta.apache.org by Henri Yandell <fl...@gmail.com> on 2007/01/29 20:49:52 UTC
Re: DO NOT REPLY [Bug 17388] - Result set created in query tag is never released + update tag
I put together a Derby test bit for a different issue that I ended up
WONTFIXing. I could add this in so you can make a test for this issue?
Hen
On 1/29/07, bugzilla@apache.org <bu...@apache.org> wrote:
> DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
> RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
> <http://issues.apache.org/bugzilla/show_bug.cgi?id=17388>.
> ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
> INSERTED IN THE BUG DATABASE.
>
> http://issues.apache.org/bugzilla/show_bug.cgi?id=17388
>
>
>
>
>
> ------- Additional Comments From kris@dotech.com 2007-01-29 11:04 -------
> Just a quick note that I checked-in a fix last week (r499150):
>
> http://svn.apache.org/viewvc/jakarta/taglibs/proper/standard/trunk/src/org/apache/taglibs/standard/tag/common/sql/QueryTagSupport.java?view=diff&rev=499150&r1=499149&r2=499150
>
> I guess I won't close this until it can be tested properly...
>
> --
> Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You are the assignee for the bug, or are watching the assignee.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: taglibs-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: taglibs-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: taglibs-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: taglibs-dev-help@jakarta.apache.org
Re: DO NOT REPLY [Bug 17388] - Result set created in query tag is never released + update tag
Posted by Henri Yandell <fl...@gmail.com>.
On 1/29/07, Kris Schneider <kr...@dotech.com> wrote:
> Henri Yandell wrote:
> > I put together a Derby test bit for a different issue that I ended up
> > WONTFIXing. I could add this in so you can make a test for this issue?
>
> If you think that'll work, sure. I haven't given the test too much thought
> yet ;-). I should probably go back and make similar changes in
> UpdateTagSupport. I know it already takes care of closing the
> PreparedStatement, but there can still be some exception "hiding". I'm also
> not sure why Throwable is being caught in those two tags...
Committed. It's part of the Cactus test suite, which is a pain in the
arse to setup the first time. If you've not got that setup yet, let me
know if you hit any problems.
Hen
---------------------------------------------------------------------
To unsubscribe, e-mail: taglibs-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: taglibs-dev-help@jakarta.apache.org
Re: DO NOT REPLY [Bug 17388] - Result set created in query tag is
never released + update tag
Posted by Kris Schneider <kr...@dotech.com>.
Henri Yandell wrote:
> I put together a Derby test bit for a different issue that I ended up
> WONTFIXing. I could add this in so you can make a test for this issue?
If you think that'll work, sure. I haven't given the test too much thought
yet ;-). I should probably go back and make similar changes in
UpdateTagSupport. I know it already takes care of closing the
PreparedStatement, but there can still be some exception "hiding". I'm also
not sure why Throwable is being caught in those two tags...
> Hen
>
> On 1/29/07, bugzilla@apache.org <bu...@apache.org> wrote:
>
>> DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
>> RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
>> <http://issues.apache.org/bugzilla/show_bug.cgi?id=17388>.
>> ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
>> INSERTED IN THE BUG DATABASE.
>>
>> http://issues.apache.org/bugzilla/show_bug.cgi?id=17388
>>
>>
>>
>>
>>
>> ------- Additional Comments From kris@dotech.com 2007-01-29 11:04
>> -------
>> Just a quick note that I checked-in a fix last week (r499150):
>>
>> http://svn.apache.org/viewvc/jakarta/taglibs/proper/standard/trunk/src/org/apache/taglibs/standard/tag/common/sql/QueryTagSupport.java?view=diff&rev=499150&r1=499149&r2=499150
>>
>>
>> I guess I won't close this until it can be tested properly...
>>
>> --
>> Configure bugmail:
>> http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
>> ------- You are receiving this mail because: -------
>> You are the assignee for the bug, or are watching the assignee.
--
Kris Schneider <ma...@dotech.com>
D.O.Tech <http://www.dotech.com/>
---------------------------------------------------------------------
To unsubscribe, e-mail: taglibs-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: taglibs-dev-help@jakarta.apache.org