You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/05/24 19:20:21 UTC
[GitHub] [incubator-pekko] mdedetrich opened a new pull request, #341: Add unwrap single string into .git-ignore-blame-revs
mdedetrich opened a new pull request, #341:
URL: https://github.com/apache/incubator-pekko/pull/341
Adds the changes from https://github.com/apache/incubator-pekko/pull/327 into `.git-ignore-blame-revs`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on pull request #341: Add unwrap single string into .git-ignore-blame-revs
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #341:
URL: https://github.com/apache/incubator-pekko/pull/341#issuecomment-1562184901
I think the change in the previous pr is a refractory but not a format, maybe this is not needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #341: Add unwrap single string into .git-ignore-blame-revs
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #341:
URL: https://github.com/apache/incubator-pekko/pull/341#issuecomment-1562357895
> I don't think this should be done. I can agree to using this file for formatting only changes but I don't think code refactors like this should not be treated like this.
This is a formatting only change, it has zero impact on any business logic or code. I was quite meticulous in doing/checming this.
Unwrapping single string definitions isn't any different to lets say removing redundant parens which scalafmt does and hence the massive scafmt which we did at the start of the fork has these kinds of changes as well.
There are also other commits in `.git-ignore-blame-revs` with similar reasoning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #341: Add unwrap single string into .git-ignore-blame-revs
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #341:
URL: https://github.com/apache/incubator-pekko/pull/341#issuecomment-1561827507
I don't think this should be done. I can agree to using this file for formatting only changes but I don't think code refactors like this should not be treated like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich merged pull request #341: Add unwrap single string into .git-ignore-blame-revs
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #341:
URL: https://github.com/apache/incubator-pekko/pull/341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org