You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@joshua.apache.org by KellenSunderland <gi...@git.apache.org> on 2016/06/02 12:56:35 UTC
[GitHub] incubator-joshua pull request #22: This patch enables junit tests. Fixes a b...
GitHub user KellenSunderland opened a pull request:
https://github.com/apache/incubator-joshua/pull/22
This patch enables junit tests. Fixes a bug with FeatureVector
Re-enabled JUnit tests with a newer surefire plugin; fixed some of the tests; KenLM tests have been temporarily disabled. Cleaned whitespace. Fixed a bug in featurevector
Run with "mvn test"
From Eclipse in Package Explorer right click on the package and "Run As -> JUnit"
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/KellenSunderland/incubator-joshua master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-joshua/pull/22.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22
----
commit b1743cbad58523a6f33883fe971c20098fd5153c
Author: Kellen Sunderland <ke...@amazon.com>
Date: 2016-06-02T12:46:31Z
Re-enabled JUnit tests with a newer surefire plugin; fixed some of the tests; KenLM tests have been temporarily disabled. Cleaned whitespace. Fixed a bug in featurevector
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-joshua issue #22: This patch enables junit tests. Fixes a bug with...
Posted by KellenSunderland <gi...@git.apache.org>.
Github user KellenSunderland commented on the issue:
https://github.com/apache/incubator-joshua/pull/22
Thanks for the merge. Looks like there's two tests still failing. The build server is complaining about basicVocabTest, and you have issues with the multithreaded tests. I'll take look at both of these.
I'll come totally clean here and admit I'm mostly testing with either intellij or 'mvn test'.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-joshua issue #22: This patch enables junit tests. Fixes a bug with...
Posted by mjpost <gi...@git.apache.org>.
Github user mjpost commented on the issue:
https://github.com/apache/incubator-joshua/pull/22
I am in fact, thanks, @logogin. I'll try to post next week :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-joshua issue #22: This patch enables junit tests. Fixes a bug with...
Posted by mjpost <gi...@git.apache.org>.
Github user mjpost commented on the issue:
https://github.com/apache/incubator-joshua/pull/22
Okay, I merged this. Notes:
- To get it working, I had to rerun "mvn eclipse:eclipse"
- I also had to rebuild the JUnit test configuration. I think this might have to do with me not quite understanding JUnit eclipse integration
- I still have one unit test failing: `givenPackedGrammar_whenNTranslationsCalledConcurrently_thenReturnNResults()` (in `MultithreadedTranslationTest`)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-joshua issue #22: This patch enables junit tests. Fixes a bug with...
Posted by logogin <gi...@git.apache.org>.
Github user logogin commented on the issue:
https://github.com/apache/incubator-joshua/pull/22
Matt, I hope you are using [m2e](http://www.eclipse.org/m2e/) integration for Eclipse. It supports native maven project structures and test classpath generation. Could you please post stack traces for failing tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-joshua issue #22: This patch enables junit tests. Fixes a bug with...
Posted by mjpost <gi...@git.apache.org>.
Github user mjpost commented on the issue:
https://github.com/apache/incubator-joshua/pull/22
I am happy to have just learned about "mvn test" :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-joshua pull request #22: This patch enables junit tests. Fixes a b...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-joshua/pull/22
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---