[GitHub] [activemq-artemis] erwindon edited a comment on pull request #3638: ARTEMIS-3369 only remove destination prefixes that are recognized

[GitBox <gi...@apache.org>]

erwindon edited a comment on pull request #3638:
URL: https://github.com/apache/activemq-artemis/pull/3638#issuecomment-873396557


   my test cases are command-line based (as this is a fix for the cli).
   
   BEFORE:
   `artemis consumer --protocol amqp --url amqp://localhost:5672 --destination topic://dest1` --> ok, server sees topic "dest1"
   `artemis consumer --protocol amqp --url amqp://localhost:5672 --destination queue://dest2` --> ok, server sees queue "dest2"
   `artemis consumer --protocol amqp --url amqp://localhost:5672 --destination xyz://dest3` --> FAIL, server sees queue "dest3", the prefix `xyz://` was not recognized by the CLI and was still removed.
   
   AFTER:
   `artemis consumer --protocol amqp --url amqp://localhost:5672 --destination topic://dest1` --> ok, server sees topic "dest1", same behaviour as before
   `artemis consumer --protocol amqp --url amqp://localhost:5672 --destination queue://dest2` --> ok, server sees topic "dest2", same behaviour as before
   `artemis consumer --protocol amqp --url amqp://localhost:5672 --destination xyz://dest3` --> ok, server sees queue `xyz://dest3`, the prefix `xyz://` was not recognized by the CLI and was now not removed. this allows the free use of prefixes that are recognized by the server in the `anycastPrefix` or `multicastPrefix` as configured with an acceptor.
   
   See also https://activemq.apache.org/components/artemis/documentation/latest/address-model.html#configuring-an-anycast-prefix for the documentation on these prefixes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org