You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cxf.apache.org by re...@apache.org on 2021/06/17 02:03:48 UTC
[cxf] 01/02: CXF-8534: Fix
org.apache.cxf.jaxrs.client.logging.RESTLoggingTest.testBinary (#815)
This is an automated email from the ASF dual-hosted git repository.
reta pushed a commit to branch 3.3.x-fixes
in repository https://gitbox.apache.org/repos/asf/cxf.git
commit a593049c61573cd3da2996b552d585d69faee0d1
Author: Andriy Redko <dr...@gmail.com>
AuthorDate: Wed Jun 16 20:36:48 2021 -0400
CXF-8534: Fix org.apache.cxf.jaxrs.client.logging.RESTLoggingTest.testBinary (#815)
(cherry picked from commit e8ff7db98b357cb5c935ae19fe3da59380d1233b)
(cherry picked from commit 5127b65c1c21dc1a79b82f078b8cd01f9cf5ba19)
---
.../cxf/jaxrs/client/logging/RESTLoggingTest.java | 37 ++++++++++++++++------
1 file changed, 27 insertions(+), 10 deletions(-)
diff --git a/rt/rs/client/src/test/java/org/apache/cxf/jaxrs/client/logging/RESTLoggingTest.java b/rt/rs/client/src/test/java/org/apache/cxf/jaxrs/client/logging/RESTLoggingTest.java
index fbfdcfe..6c81b20 100644
--- a/rt/rs/client/src/test/java/org/apache/cxf/jaxrs/client/logging/RESTLoggingTest.java
+++ b/rt/rs/client/src/test/java/org/apache/cxf/jaxrs/client/logging/RESTLoggingTest.java
@@ -62,31 +62,48 @@ public class RESTLoggingTest {
LoggingFeature loggingFeature = new LoggingFeature();
TestEventSender sender = new TestEventSender();
loggingFeature.setSender(sender);
+ loggingFeature.setLogBinary(true);
+
Server server = createService(SERVICE_URI_BINARY, new TestServiceRestBinary(), loggingFeature);
server.start();
WebClient client = createClient(SERVICE_URI_BINARY, loggingFeature);
client.get(InputStream.class).close();
- loggingFeature.setLogBinary(true);
+ client.close();
+
+ List<LogEvent> events = sender.getEvents();
+ await().until(() -> events.size(), is(4));
+ server.stop();
+ server.destroy();
+
+ Assert.assertEquals(4, events.size());
+
+ assertContentLogged(events.get(0));
+ assertContentLogged(events.get(1));
+ assertContentLogged(events.get(2));
+ assertContentLogged(events.get(3));
+ }
+
+ @Test
+ public void testNonBinary() throws IOException, InterruptedException {
+ LoggingFeature loggingFeature = new LoggingFeature();
+ TestEventSender sender = new TestEventSender();
+ loggingFeature.setSender(sender);
+ Server server = createService(SERVICE_URI_BINARY, new TestServiceRestBinary(), loggingFeature);
+ server.start();
+ WebClient client = createClient(SERVICE_URI_BINARY, loggingFeature);
client.get(InputStream.class).close();
client.close();
List<LogEvent> events = sender.getEvents();
- await().until(() -> events.size(), is(8));
+ await().until(() -> events.size(), is(4));
server.stop();
server.destroy();
- Assert.assertEquals(8, events.size());
+ Assert.assertEquals(4, events.size());
- // First call with binary logging false
assertContentLogged(events.get(0));
assertContentLogged(events.get(1));
assertContentNotLogged(events.get(2));
assertContentNotLogged(events.get(3));
-
- // Second call with binary logging true
- assertContentLogged(events.get(4));
- assertContentLogged(events.get(5));
- assertContentLogged(events.get(6));
- assertContentLogged(events.get(7));
}
@Test