You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/06/21 17:25:00 UTC
[jira] [Work logged] (GOBBLIN-1841) Move disabling of current live instances to the GobblinClusterManager startup
[ https://issues.apache.org/jira/browse/GOBBLIN-1841?focusedWorklogId=866807&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-866807 ]
ASF GitHub Bot logged work on GOBBLIN-1841:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jun/23 17:24
Start Date: 21/Jun/23 17:24
Worklog Time Spent: 10m
Work Description: Peiyingy opened a new pull request, #3708:
URL: https://github.com/apache/gobblin/pull/3708
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-1841] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1841
### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
The method `disableLiveHelixInstances()` originally exists in `GobblinYarnAppLauncher` to disable pre-existing live instances in a Helix cluster. However, there are situations where these orphaned instances still exist while the disable method is not triggered at the Yarn level.
Thus, we moved this method to `GobblinClusterManager`, and invokes it at the start stage, to guarantee that each time these pre-existing live instances can be disabled.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
<img width="518" alt="Screenshot 2023-06-21 at 10 21 26 AM" src="https://github.com/apache/gobblin/assets/112960226/6d7468ce-8826-4984-8d2b-7812e503e02d">
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 866807)
Remaining Estimate: 0h
Time Spent: 10m
> Move disabling of current live instances to the GobblinClusterManager startup
> -----------------------------------------------------------------------------
>
> Key: GOBBLIN-1841
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1841
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Matthew Ho
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)