You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Jan Vermeulen (JIRA)" <ji...@apache.org> on 2007/08/28 19:39:30 UTC
[jira] Created: (WICKET-903) WicketServlet no longer sets
application on current thread
WicketServlet no longer sets application on current thread
----------------------------------------------------------
Key: WICKET-903
URL: https://issues.apache.org/jira/browse/WICKET-903
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.3.0-beta3, 1.3.0-beta4, 1.3.0-rc1, 1.3.0-final, 1.4.0-alpha, 1.3.1
Environment: Windows, OSGI-platform
Reporter: Jan Vermeulen
Priority: Critical
The last changes made to WicketFilter (move Application.set(webApplication) from doGet() to doFilter()) have a side effect: if working with WicketServlet (due to OSGI), the application is no longer set on the current thread, because it was moved to doFilter().
Possible fixes:
* move Application.set() in WicketFilter back to doGet(), at the start if that's early enough
* expose the webApplication property, and add an extra Application.set() in the doGet() of WicketServlet
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-903) WicketServlet no longer sets
application on current thread
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Compagner reassigned WICKET-903:
--------------------------------------
Assignee: Eelco Hillenius
eelco broke it, so he know ofcourse exactly how to fix it.
> WicketServlet no longer sets application on current thread
> ----------------------------------------------------------
>
> Key: WICKET-903
> URL: https://issues.apache.org/jira/browse/WICKET-903
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta3, 1.3.0-beta4, 1.3.0-rc1, 1.3.0-final, 1.4.0-alpha, 1.3.1
> Environment: Windows, OSGI-platform
> Reporter: Jan Vermeulen
> Assignee: Eelco Hillenius
> Priority: Critical
>
> The last changes made to WicketFilter (move Application.set(webApplication) from doGet() to doFilter()) have a side effect: if working with WicketServlet (due to OSGI), the application is no longer set on the current thread, because it was moved to doFilter().
> Possible fixes:
> * move Application.set() in WicketFilter back to doGet(), at the start if that's early enough
> * expose the webApplication property, and add an extra Application.set() in the doGet() of WicketServlet
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-903) WicketServlet no longer sets
application on current thread
Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eelco Hillenius resolved WICKET-903.
------------------------------------
Resolution: Fixed
Fix Version/s: 1.3.0-beta4
> WicketServlet no longer sets application on current thread
> ----------------------------------------------------------
>
> Key: WICKET-903
> URL: https://issues.apache.org/jira/browse/WICKET-903
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta3, 1.3.0-beta4, 1.3.0-rc1, 1.3.0-final, 1.4.0-alpha, 1.3.1
> Environment: Windows, OSGI-platform
> Reporter: Jan Vermeulen
> Assignee: Eelco Hillenius
> Priority: Critical
> Fix For: 1.3.0-beta4
>
>
> The last changes made to WicketFilter (move Application.set(webApplication) from doGet() to doFilter()) have a side effect: if working with WicketServlet (due to OSGI), the application is no longer set on the current thread, because it was moved to doFilter().
> Possible fixes:
> * move Application.set() in WicketFilter back to doGet(), at the start if that's early enough
> * expose the webApplication property, and add an extra Application.set() in the doGet() of WicketServlet
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-903) WicketServlet no longer sets
application on current thread
Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523292 ]
Eelco Hillenius commented on WICKET-903:
----------------------------------------
Damn! Sorry for that, I'll look into it today.
> WicketServlet no longer sets application on current thread
> ----------------------------------------------------------
>
> Key: WICKET-903
> URL: https://issues.apache.org/jira/browse/WICKET-903
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta3, 1.3.0-beta4, 1.3.0-rc1, 1.3.0-final, 1.4.0-alpha, 1.3.1
> Environment: Windows, OSGI-platform
> Reporter: Jan Vermeulen
> Assignee: Eelco Hillenius
> Priority: Critical
>
> The last changes made to WicketFilter (move Application.set(webApplication) from doGet() to doFilter()) have a side effect: if working with WicketServlet (due to OSGI), the application is no longer set on the current thread, because it was moved to doFilter().
> Possible fixes:
> * move Application.set() in WicketFilter back to doGet(), at the start if that's early enough
> * expose the webApplication property, and add an extra Application.set() in the doGet() of WicketServlet
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.