[GitHub] [solr] dsmiley commented on pull request #657: SOLR-14401: Track distrib/shard metrics differently

[GitBox <gi...@apache.org>]

dsmiley commented on pull request #657:
URL: https://github.com/apache/solr/pull/657#issuecomment-1058073565


   Definitely see JIRA for my overall comments.
   
   I want to point out that I observed that the "totalTime" metric has been a nanosecond number in recent years, yet once upon a time it was milliseconds.  This change was very likely inadvertent.  Our prometheus solr-exporter-config.xml shows that it *thinks* it's milliseconds.  It's not; RequestHandlerBase increments this counter by "elapsed", the response of `timer.stop()` -- nanoseconds.  Years ago it had invoked `MetricUtils.nsToMs(` but it appears @sigram removed this as a part of other changes in 2017 sometime -- https://github.com/apache/solr/commit/d8df9f8c9963c2fc1718fd471316bf5d964125ba


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org