[GitHub] [libcloud] Kami edited a comment on pull request #1584: Optimized 'iterate_container_objects' by filtering the objects before…

[GitBox <gi...@apache.org>]

Kami edited a comment on pull request #1584:
URL: https://github.com/apache/libcloud/pull/1584#issuecomment-983881324


   @louis-van-der-stam #1631 should fix this regression. Sadly we didn't have an existing test cases for this scenario which would have caught this issue early. Can you please verify the fix?
   
   @Ido-Levi Thanks for your original contribution and good intention with the performance optimization, but sadly the change needs to be reverted since it breaks the expected behavior (prefix filtering being applied against the object name - which may include actual bucket name, but that's provider / implementation specific).
   
   EDIT: Thinking about it some more, we may still be able to introduce optimization for some scenarios in the future (perhaps by checking if the name contains path separator or similar, but that would only apply to some scenarios and likely also has more edge cases which we need to handle correctly).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org