[GitHub] [kafka] dejan2609 commented on a change in pull request #10626: KAFKA-12744: Breaking change dependency upgrade: "argparse4j" 0.7.0 -->> 0.9.0

[GitBox <gi...@apache.org>]

dejan2609 commented on a change in pull request #10626:
URL: https://github.com/apache/kafka/pull/10626#discussion_r624694456



##########
File path: shell/src/main/java/org/apache/kafka/shell/ManCommandHandler.java
##########
@@ -87,7 +87,7 @@ public void run(Optional<InteractiveShell> shell,
             writer.println("man: unknown command " + cmd +
                 ". Type help to get a list of commands.");
         } else {
-            ArgumentParser parser = ArgumentParsers.newArgumentParser(type.name(), false);
+            ArgumentParser parser = ArgumentParsers.newFor(type.name()).build();

Review comment:
       This also needs a review.

##########
File path: shell/src/main/java/org/apache/kafka/shell/Commands.java
##########
@@ -95,7 +95,7 @@ void completeNext(MetadataNodeManager nodeManager,
      * @param addShellCommands  True if we should include the shell-only commands.
      */
     public Commands(boolean addShellCommands) {
-        this.parser = ArgumentParsers.newArgumentParser("", false);
+        this.parser = ArgumentParsers.newFor("shell-commands").build();

Review comment:
       Note: I think need a review for this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org