You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "wg1026688210 (via GitHub)" <gi...@apache.org> on 2023/08/11 12:27:54 UTC

[GitHub] [incubator-paimon] wg1026688210 opened a new pull request, #1798: [hive] extern table remove file by mistask when create table failed

wg1026688210 opened a new pull request, #1798:
URL: https://github.com/apache/incubator-paimon/pull/1798

   <!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
   
   ### Purpose
   When attempting to create a  hive extern table  for an existing Paimon, if the table creation fails, the Paimon table will be deleted, which is not expected.
   The pr is for reproduce the problem.And then fix it
   
   ### Tests
   CreateTableITCase#createExternTableFailing
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-paimon] JingsongLi merged pull request #1798: [hive] extern table remove file by mistake when create table failed

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #1798:
URL: https://github.com/apache/incubator-paimon/pull/1798


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-paimon] JingsongLi commented on a diff in pull request #1798: [hive] extern table remove file by mistake when create table failed

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #1798:
URL: https://github.com/apache/incubator-paimon/pull/1798#discussion_r1293488376


##########
paimon-hive/paimon-hive-connector-common/src/main/java/org/apache/paimon/hive/PaimonMetaHook.java:
##########
@@ -62,6 +63,9 @@ public class PaimonMetaHook implements HiveMetaHook {
     private static final String COMMENT = "comment";
     private final Configuration conf;
 
+    // paimon table existed before create hive table
+    private Set<Identifier> existingPaimonTable = new HashSet<>();

Review Comment:
   final



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org