You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by si...@apache.org on 2018/12/21 05:50:10 UTC
[pulsar.wiki] branch master updated: Updated PIP 27: Add checklist
in github pull request template (markdown)
This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.wiki.git
The following commit(s) were added to refs/heads/master by this push:
new 8ef0ca7 Updated PIP 27: Add checklist in github pull request template (markdown)
8ef0ca7 is described below
commit 8ef0ca709f0d05048a34532c0ce32b664aedf647
Author: Sijie Guo <gu...@gmail.com>
AuthorDate: Fri Dec 21 13:50:09 2018 +0800
Updated PIP 27: Add checklist in github pull request template (markdown)
---
PIP-27:-Add-checklist-in-github-pull-request-template.md | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/PIP-27:-Add-checklist-in-github-pull-request-template.md b/PIP-27:-Add-checklist-in-github-pull-request-template.md
index 76ce7ef..5262cbf 100644
--- a/PIP-27:-Add-checklist-in-github-pull-request-template.md
+++ b/PIP-27:-Add-checklist-in-github-pull-request-template.md
@@ -61,11 +61,15 @@ This change added tests and can be verified as follows:
## Does this pull request potentially affect one of the following parts:
+*If `yes` was chosen, please highlight the changes*
+
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
+ - The rest endpoints: (yes / no)
+ - The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
## Documentation