[GitHub] [netbeans] junichi11 opened a new pull request #1510: [NETBEANS-3103] Formatting is broken with class constant code completion(self::)

[GitBox <gi...@apache.org>]

junichi11 opened a new pull request #1510: [NETBEANS-3103] Formatting is broken with class constant code completion(self::)
URL: https://github.com/apache/netbeans/pull/1510
 
 
   https://issues.apache.org/jira/browse/NETBEANS-3103
   
   This issue is related to #1314 .
   
   - The parser ignores "::" because example code is incorrect syntax
   - Check whether the token behind self or parent is "::" in the FormatVisitor
   
   Example code:
   ```php
   <?php
   class ClassName {
   
       // ^ is the caret position
       // select "self::" or "parent::" in CC list
       // i.e. private const CONSTANT = self::;
       private const CONSTANT = ^;
   
   }
   ```
   
   Before:
   ```php
   <?php
   class ClassName {
   
       private const CONSTANT = self
   
       ::;
   
   }
   ```
   
   After:
   ```php
   <?php
   class ClassName {
   
       private const CONSTANT = self::;
   
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists