[jira] Commented: (THRIFT-25) improvements to C# compiler and library

["Michael Greene (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658957#action_12658957 ] 

Michael Greene commented on THRIFT-25:
--------------------------------------

This has taken a backseat for me, however I got some time to look at it today.

It looks like the only two problems with the git branch are the two I mentioned:
test/csharp/ThriftTest/Properties/AssemblyInfo.cs should begin
{{using System.Reflection;}}
and not just
{{System.Reflection;}}

and

test/csharp/ThriftTest/Program.cs is "doubled".

I'm not very good with git and unsure how to incorporate your changes and these revisions into a single new patch though.

> improvements to C# compiler and library
> ---------------------------------------
>
>                 Key: THRIFT-25
>                 URL: https://issues.apache.org/jira/browse/THRIFT-25
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (C#), Library (C#)
>         Environment: Windows
>            Reporter: Will Palmeri
>         Attachments: csharpimprovements-nospace2.patch, csharpimprovements.patch
>
>
> We have a patch with lots of changes to the C# compiler and libary.
> Compiler:
> -thrift structures are serializable
> -the member fields of thrift structures are now private and only accessible through Properties, which keep the appropriate __isset up to date
> Library
> -addition of TBufferedTransport, which can be used to wrap other Transports.  I saw a 10x improvement in the test client when using buffered sockets
> -addition of TThreadedServer. manually manages threads instead of relying on .net ThreadPool
> -servers use a log delegate. defaults to System.Console, but allows servers to use log4net without introducing the dependency.
> ThriftTest visual studio project
> -test client and server that uses ThriftTest.thrift. The project references thrift.exe and Thrift.dll from the subversion tree and automatically builds generated code. This makes it very easy to test changes in both the compiler and library.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.