You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2019/11/15 02:13:08 UTC

[GitHub] [incubator-dolphinscheduler] Baoqi opened a new issue #1245: [BUG] when Master Server scanCommand, in rare case, there maybe dirty data saved into ProcessInstance due to Transactional logic problem

Baoqi opened a new issue #1245: [BUG] when Master Server scanCommand, in rare case, there maybe dirty data saved into ProcessInstance due to Transactional logic problem
URL: https://github.com/apache/incubator-dolphinscheduler/issues/1245
 
 
   Currently, in scanCommand, the exception is swallowed inside try{} catch{}, so, the transational is not working as expected. 
   
   https://github.com/apache/incubator-dolphinscheduler/blob/dev-db/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/ProcessDao.java#L146
   
   ![图片](https://user-images.githubusercontent.com/4434603/68911560-60dcf580-0790-11ea-8167-ee9840adbd7e.png)
   
   If the lines (marked in red rectangle) throws exception. The processinstance will still be saved. but no thread will be created to handle this one. 
   
   
   I will provide PR for this.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services