[jira] [Commented] (HIVE-9096) GenericUDF may be left unclosed in PartitionPrune#visitCall()

["Hive QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-9096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14249573#comment-14249573 ] 

Hive QA commented on HIVE-9096:
-------------------------------



{color:red}Overall{color}: -1 at least one tests failed

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12687086/HIVE-9096.patch

{color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 6713 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_vector_partition_diff_num_cols
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_optimize_nullscan
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_vector_partition_diff_num_cols
{noformat}

Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2102/testReport
Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2102/console
Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-2102/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 3 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12687086 - PreCommit-HIVE-TRUNK-Build

> GenericUDF may be left unclosed in PartitionPrune#visitCall()
> -------------------------------------------------------------
>
>                 Key: HIVE-9096
>                 URL: https://issues.apache.org/jira/browse/HIVE-9096
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>         Attachments: HIVE-9096.patch
>
>
> In ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/PartitionPrune.java :
> {code}
>       GenericUDF hiveUDF = SqlFunctionConverter.getHiveUDF(call.getOperator(),
>           call.getType(), call.operands.size());
>       if (hiveUDF != null &&
>           !FunctionRegistry.isDeterministic(hiveUDF)) {
>         return null;
>       }
> {code}
> hiveUDF should be closed upon return.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)