You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "allisonwang-db (via GitHub)" <gi...@apache.org> on 2023/03/28 08:24:48 UTC
[GitHub] [spark] allisonwang-db opened a new pull request, #40575: [SPARK-42945][CONNECT] Support PYSPARK_JVM_STACKTRACE_ENABLED in Spark Connect
allisonwang-db opened a new pull request, #40575:
URL: https://github.com/apache/spark/pull/40575
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR supports `spark.sql.pyspark.jvmStacktrace.enabled` in Spark Connect to optionally show the JVM stack trace.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To support an existing config that works with legacy PySpark.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
New unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] grundprinzip commented on a diff in pull request #40575: [SPARK-42945][CONNECT] Support PYSPARK_JVM_STACKTRACE_ENABLED in Spark Connect
Posted by "grundprinzip (via GitHub)" <gi...@apache.org>.
grundprinzip commented on code in PR #40575:
URL: https://github.com/apache/spark/pull/40575#discussion_r1169530192
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala:
##########
@@ -109,23 +118,41 @@ class SparkConnectService(debug: Boolean)
*/
private def handleError[V](
opType: String,
- observer: StreamObserver[V]): PartialFunction[Throwable, Unit] = {
- case se: SparkException if isPythonExecutionException(se) =>
- logError(s"Error during: $opType", se)
- observer.onError(
- StatusProto.toStatusRuntimeException(buildStatusFromThrowable(se.getCause)))
-
- case e: Throwable if e.isInstanceOf[SparkThrowable] || NonFatal.apply(e) =>
- logError(s"Error during: $opType", e)
- observer.onError(StatusProto.toStatusRuntimeException(buildStatusFromThrowable(e)))
-
- case e: Throwable =>
- logError(s"Error during: $opType", e)
- observer.onError(
- Status.UNKNOWN
- .withCause(e)
- .withDescription(StringUtils.abbreviate(e.getMessage, 2048))
- .asRuntimeException())
+ observer: StreamObserver[V],
+ userId: String,
+ sessionId: String): PartialFunction[Throwable, Unit] = {
+ val session =
+ SparkConnectService
+ .getOrCreateIsolatedSession(userId, sessionId)
+ .session
+ val stackTraceEnabled = try {
+ session.conf.get(
+ org.apache.spark.sql.internal.SQLConf.PYSPARK_JVM_STACKTRACE_ENABLED.key).toBoolean
+ } catch {
+ case NonFatal(_) => true
+ }
+
+ {
+ case se: SparkException if isPythonExecutionException(se) =>
+ logError(s"Error during: $opType", se)
Review Comment:
Makes sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #40575: [SPARK-42945][CONNECT] Support PYSPARK_JVM_STACKTRACE_ENABLED in Spark Connect
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #40575: [SPARK-42945][CONNECT] Support PYSPARK_JVM_STACKTRACE_ENABLED in Spark Connect
URL: https://github.com/apache/spark/pull/40575
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] grundprinzip commented on a diff in pull request #40575: [SPARK-42945][CONNECT] Support PYSPARK_JVM_STACKTRACE_ENABLED in Spark Connect
Posted by "grundprinzip (via GitHub)" <gi...@apache.org>.
grundprinzip commented on code in PR #40575:
URL: https://github.com/apache/spark/pull/40575#discussion_r1151047796
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala:
##########
@@ -143,7 +170,13 @@ class SparkConnectService(debug: Boolean)
responseObserver: StreamObserver[proto.ExecutePlanResponse]): Unit = {
try {
new SparkConnectStreamHandler(responseObserver).handle(request)
- } catch handleError("execute", observer = responseObserver)
+ } catch {
+ handleError(
+ "execute",
+ observer = responseObserver,
+ userId = request.getUserContext.getUserId,
+ sessionId = request.getSessionId)
Review Comment:
user context should not be null, userid and session id can be null (but should not). Better safe than sorry is my motto here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] grundprinzip commented on a diff in pull request #40575: [SPARK-42945][CONNECT] Support PYSPARK_JVM_STACKTRACE_ENABLED in Spark Connect
Posted by "grundprinzip (via GitHub)" <gi...@apache.org>.
grundprinzip commented on code in PR #40575:
URL: https://github.com/apache/spark/pull/40575#discussion_r1151047011
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala:
##########
@@ -73,18 +74,26 @@ class SparkConnectService(debug: Boolean)
classes.toSeq
}
- private def buildStatusFromThrowable(st: Throwable): RPCStatus = {
+ private def buildStatusFromThrowable(
+ st: Throwable,
+ stackTraceEnabled: Boolean = false): RPCStatus = {
+ val errorInfo = ErrorInfo
+ .newBuilder()
+ .setReason(st.getClass.getName)
+ .setDomain("org.apache.spark")
+ .putMetadata("classes", compact(render(allClasses(st.getClass).map(_.getName))))
+
+ val withStackTrace = if (stackTraceEnabled) {
+ val stackTrace = ExceptionUtils.getStackTrace(st)
+ errorInfo.putMetadata("stackTrace", StringUtils.abbreviate(stackTrace, 4096))
Review Comment:
Abbreviated to 4k characters, does this still produce reasonable stack traces? Do we know how actionable this is for a spark connect client?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] allisonwang-db commented on a diff in pull request #40575: [SPARK-42945][CONNECT] Support PYSPARK_JVM_STACKTRACE_ENABLED in Spark Connect
Posted by "allisonwang-db (via GitHub)" <gi...@apache.org>.
allisonwang-db commented on code in PR #40575:
URL: https://github.com/apache/spark/pull/40575#discussion_r1154490873
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala:
##########
@@ -73,18 +74,26 @@ class SparkConnectService(debug: Boolean)
classes.toSeq
}
- private def buildStatusFromThrowable(st: Throwable): RPCStatus = {
+ private def buildStatusFromThrowable(
+ st: Throwable,
+ stackTraceEnabled: Boolean = false): RPCStatus = {
+ val errorInfo = ErrorInfo
+ .newBuilder()
+ .setReason(st.getClass.getName)
+ .setDomain("org.apache.spark")
+ .putMetadata("classes", compact(render(allClasses(st.getClass).map(_.getName))))
+
+ val withStackTrace = if (stackTraceEnabled) {
+ val stackTrace = ExceptionUtils.getStackTrace(st)
+ errorInfo.putMetadata("stackTrace", StringUtils.abbreviate(stackTrace, 4096))
Review Comment:
This is a good question. I wonder if we should make this configurable for users.
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala:
##########
@@ -73,18 +74,26 @@ class SparkConnectService(debug: Boolean)
classes.toSeq
}
- private def buildStatusFromThrowable(st: Throwable): RPCStatus = {
+ private def buildStatusFromThrowable(
+ st: Throwable,
+ stackTraceEnabled: Boolean = false): RPCStatus = {
+ val errorInfo = ErrorInfo
+ .newBuilder()
+ .setReason(st.getClass.getName)
+ .setDomain("org.apache.spark")
+ .putMetadata("classes", compact(render(allClasses(st.getClass).map(_.getName))))
+
+ val withStackTrace = if (stackTraceEnabled) {
+ val stackTrace = ExceptionUtils.getStackTrace(st)
+ errorInfo.putMetadata("stackTrace", StringUtils.abbreviate(stackTrace, 4096))
+ } else {
+ errorInfo
+ }
+
RPCStatus
.newBuilder()
.setCode(RPCCode.INTERNAL_VALUE)
- .addDetails(
- ProtoAny.pack(
- ErrorInfo
- .newBuilder()
- .setReason(st.getClass.getName)
- .setDomain("org.apache.spark")
- .putMetadata("classes", compact(render(allClasses(st.getClass).map(_.getName))))
- .build()))
+ .addDetails(ProtoAny.pack(withStackTrace.build()))
Review Comment:
The stack trace is disabled by default, so it should not affect typical users. But I agree it can be hard to debug such issues. One solution could be to make the stack trace size configurable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jaceklaskowski commented on a diff in pull request #40575: [SPARK-42945][CONNECT] Support PYSPARK_JVM_STACKTRACE_ENABLED in Spark Connect
Posted by "jaceklaskowski (via GitHub)" <gi...@apache.org>.
jaceklaskowski commented on code in PR #40575:
URL: https://github.com/apache/spark/pull/40575#discussion_r1151040181
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala:
##########
@@ -109,23 +118,41 @@ class SparkConnectService(debug: Boolean)
*/
private def handleError[V](
opType: String,
- observer: StreamObserver[V]): PartialFunction[Throwable, Unit] = {
- case se: SparkException if isPythonExecutionException(se) =>
- logError(s"Error during: $opType", se)
- observer.onError(
- StatusProto.toStatusRuntimeException(buildStatusFromThrowable(se.getCause)))
-
- case e: Throwable if e.isInstanceOf[SparkThrowable] || NonFatal.apply(e) =>
- logError(s"Error during: $opType", e)
- observer.onError(StatusProto.toStatusRuntimeException(buildStatusFromThrowable(e)))
-
- case e: Throwable =>
- logError(s"Error during: $opType", e)
- observer.onError(
- Status.UNKNOWN
- .withCause(e)
- .withDescription(StringUtils.abbreviate(e.getMessage, 2048))
- .asRuntimeException())
+ observer: StreamObserver[V],
+ userId: String,
+ sessionId: String): PartialFunction[Throwable, Unit] = {
+ val session =
+ SparkConnectService
+ .getOrCreateIsolatedSession(userId, sessionId)
+ .session
+ val stackTraceEnabled = try {
+ session.conf.get(
+ org.apache.spark.sql.internal.SQLConf.PYSPARK_JVM_STACKTRACE_ENABLED.key).toBoolean
Review Comment:
Can you `import org.apache.spark.sql.internal.SQLConf.PYSPARK_JVM_STACKTRACE_ENABLED` right after `try {`?
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala:
##########
@@ -109,23 +118,41 @@ class SparkConnectService(debug: Boolean)
*/
private def handleError[V](
opType: String,
- observer: StreamObserver[V]): PartialFunction[Throwable, Unit] = {
- case se: SparkException if isPythonExecutionException(se) =>
- logError(s"Error during: $opType", se)
- observer.onError(
- StatusProto.toStatusRuntimeException(buildStatusFromThrowable(se.getCause)))
-
- case e: Throwable if e.isInstanceOf[SparkThrowable] || NonFatal.apply(e) =>
- logError(s"Error during: $opType", e)
- observer.onError(StatusProto.toStatusRuntimeException(buildStatusFromThrowable(e)))
-
- case e: Throwable =>
- logError(s"Error during: $opType", e)
- observer.onError(
- Status.UNKNOWN
- .withCause(e)
- .withDescription(StringUtils.abbreviate(e.getMessage, 2048))
- .asRuntimeException())
+ observer: StreamObserver[V],
+ userId: String,
+ sessionId: String): PartialFunction[Throwable, Unit] = {
+ val session =
+ SparkConnectService
+ .getOrCreateIsolatedSession(userId, sessionId)
+ .session
+ val stackTraceEnabled = try {
+ session.conf.get(
+ org.apache.spark.sql.internal.SQLConf.PYSPARK_JVM_STACKTRACE_ENABLED.key).toBoolean
+ } catch {
+ case NonFatal(_) => true
+ }
+
+ {
Review Comment:
Are the three lines above really needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #40575: [SPARK-42945][CONNECT] Support PYSPARK_JVM_STACKTRACE_ENABLED in Spark Connect
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on PR #40575:
URL: https://github.com/apache/spark/pull/40575#issuecomment-1487510024
> @allisonwang-db can we do something similar for the scala side?
Same question: do we plan to do the same on the scala side?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] allisonwang-db commented on pull request #40575: [SPARK-42945][CONNECT] Support PYSPARK_JVM_STACKTRACE_ENABLED in Spark Connect
Posted by "allisonwang-db (via GitHub)" <gi...@apache.org>.
allisonwang-db commented on PR #40575:
URL: https://github.com/apache/spark/pull/40575#issuecomment-1512438468
@grundprinzip I added a config for the stack trace size (default 4096). Could you take another look at this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a diff in pull request #40575: [SPARK-42945][CONNECT] Support PYSPARK_JVM_STACKTRACE_ENABLED in Spark Connect
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on code in PR #40575:
URL: https://github.com/apache/spark/pull/40575#discussion_r1173331870
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala:
##########
@@ -109,23 +118,42 @@ class SparkConnectService(debug: Boolean)
*/
private def handleError[V](
opType: String,
- observer: StreamObserver[V]): PartialFunction[Throwable, Unit] = {
- case se: SparkException if isPythonExecutionException(se) =>
- logError(s"Error during: $opType", se)
- observer.onError(
- StatusProto.toStatusRuntimeException(buildStatusFromThrowable(se.getCause)))
-
- case e: Throwable if e.isInstanceOf[SparkThrowable] || NonFatal.apply(e) =>
- logError(s"Error during: $opType", e)
- observer.onError(StatusProto.toStatusRuntimeException(buildStatusFromThrowable(e)))
-
- case e: Throwable =>
- logError(s"Error during: $opType", e)
- observer.onError(
- Status.UNKNOWN
- .withCause(e)
- .withDescription(StringUtils.abbreviate(e.getMessage, 2048))
- .asRuntimeException())
+ observer: StreamObserver[V],
+ userId: String,
+ sessionId: String): PartialFunction[Throwable, Unit] = {
+ val session =
+ SparkConnectService
+ .getOrCreateIsolatedSession(userId, sessionId)
+ .session
+ val stackTraceEnabled =
+ try {
+ session.conf.get(PYSPARK_JVM_STACKTRACE_ENABLED.key).toBoolean
+ } catch {
+ case NonFatal(e) =>
+ logWarning(s"Failed to get Spark conf `PYSPARK_JVM_STACKTRACE_ENABLED`: $e")
+ true
+ }
Review Comment:
```suggestion
val stackTraceEnabled = session.conf.get(PYSPARK_JVM_STACKTRACE_ENABLED.key, "true").toBoolean
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #40575: [SPARK-42945][CONNECT] Support PYSPARK_JVM_STACKTRACE_ENABLED in Spark Connect
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #40575:
URL: https://github.com/apache/spark/pull/40575#discussion_r1169562116
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala:
##########
@@ -73,19 +74,29 @@ class SparkConnectService(debug: Boolean)
classes.toSeq
}
- private def buildStatusFromThrowable(st: Throwable): RPCStatus = {
+ private def buildStatusFromThrowable(
+ st: Throwable,
+ stackTraceEnabled: Boolean = false): RPCStatus = {
Review Comment:
I think we don't need a default value here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #40575: [SPARK-42945][CONNECT] Support PYSPARK_JVM_STACKTRACE_ENABLED in Spark Connect
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #40575:
URL: https://github.com/apache/spark/pull/40575#issuecomment-1515739073
Reverting this out for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] grundprinzip commented on a diff in pull request #40575: [SPARK-42945][CONNECT] Support PYSPARK_JVM_STACKTRACE_ENABLED in Spark Connect
Posted by "grundprinzip (via GitHub)" <gi...@apache.org>.
grundprinzip commented on code in PR #40575:
URL: https://github.com/apache/spark/pull/40575#discussion_r1151045107
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala:
##########
@@ -73,18 +74,26 @@ class SparkConnectService(debug: Boolean)
classes.toSeq
}
- private def buildStatusFromThrowable(st: Throwable): RPCStatus = {
+ private def buildStatusFromThrowable(
+ st: Throwable,
+ stackTraceEnabled: Boolean = false): RPCStatus = {
+ val errorInfo = ErrorInfo
+ .newBuilder()
+ .setReason(st.getClass.getName)
+ .setDomain("org.apache.spark")
+ .putMetadata("classes", compact(render(allClasses(st.getClass).map(_.getName))))
+
+ val withStackTrace = if (stackTraceEnabled) {
+ val stackTrace = ExceptionUtils.getStackTrace(st)
+ errorInfo.putMetadata("stackTrace", StringUtils.abbreviate(stackTrace, 4096))
+ } else {
+ errorInfo
+ }
+
RPCStatus
.newBuilder()
.setCode(RPCCode.INTERNAL_VALUE)
- .addDetails(
- ProtoAny.pack(
- ErrorInfo
- .newBuilder()
- .setReason(st.getClass.getName)
- .setDomain("org.apache.spark")
- .putMetadata("classes", compact(render(allClasses(st.getClass).map(_.getName))))
- .build()))
+ .addDetails(ProtoAny.pack(withStackTrace.build()))
Review Comment:
Adding the stack trace can break the result handling. Depending on the intermediate server the stack trace might be too big for single HTTP2 frames. We internally increased this to 128k but this is not the default.
This might make it hard to debug for an intermediate party when they deploy a proxy in front of Spark Connect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] allisonwang-db commented on a diff in pull request #40575: [SPARK-42945][CONNECT] Support PYSPARK_JVM_STACKTRACE_ENABLED in Spark Connect
Posted by "allisonwang-db (via GitHub)" <gi...@apache.org>.
allisonwang-db commented on code in PR #40575:
URL: https://github.com/apache/spark/pull/40575#discussion_r1150223876
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala:
##########
@@ -109,23 +118,41 @@ class SparkConnectService(debug: Boolean)
*/
private def handleError[V](
opType: String,
- observer: StreamObserver[V]): PartialFunction[Throwable, Unit] = {
- case se: SparkException if isPythonExecutionException(se) =>
- logError(s"Error during: $opType", se)
- observer.onError(
- StatusProto.toStatusRuntimeException(buildStatusFromThrowable(se.getCause)))
-
- case e: Throwable if e.isInstanceOf[SparkThrowable] || NonFatal.apply(e) =>
- logError(s"Error during: $opType", e)
- observer.onError(StatusProto.toStatusRuntimeException(buildStatusFromThrowable(e)))
-
- case e: Throwable =>
- logError(s"Error during: $opType", e)
- observer.onError(
- Status.UNKNOWN
- .withCause(e)
- .withDescription(StringUtils.abbreviate(e.getMessage, 2048))
- .asRuntimeException())
+ observer: StreamObserver[V],
+ userId: String,
+ sessionId: String): PartialFunction[Throwable, Unit] = {
+ val session =
+ SparkConnectService
+ .getOrCreateIsolatedSession(userId, sessionId)
+ .session
+ val stackTraceEnabled = try {
+ session.conf.get(
+ org.apache.spark.sql.internal.SQLConf.PYSPARK_JVM_STACKTRACE_ENABLED.key).toBoolean
+ } catch {
+ case NonFatal(_) => true
+ }
+
+ {
+ case se: SparkException if isPythonExecutionException(se) =>
+ logError(s"Error during: $opType", se)
Review Comment:
@HyukjinKwon @grundprinzip Another thing that could improve debuggability is to include the `user_id` and `session_id` in this error log. WDYT?
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala:
##########
@@ -109,23 +118,41 @@ class SparkConnectService(debug: Boolean)
*/
private def handleError[V](
opType: String,
- observer: StreamObserver[V]): PartialFunction[Throwable, Unit] = {
- case se: SparkException if isPythonExecutionException(se) =>
- logError(s"Error during: $opType", se)
- observer.onError(
- StatusProto.toStatusRuntimeException(buildStatusFromThrowable(se.getCause)))
-
- case e: Throwable if e.isInstanceOf[SparkThrowable] || NonFatal.apply(e) =>
- logError(s"Error during: $opType", e)
- observer.onError(StatusProto.toStatusRuntimeException(buildStatusFromThrowable(e)))
-
- case e: Throwable =>
- logError(s"Error during: $opType", e)
- observer.onError(
- Status.UNKNOWN
- .withCause(e)
- .withDescription(StringUtils.abbreviate(e.getMessage, 2048))
- .asRuntimeException())
+ observer: StreamObserver[V],
+ userId: String,
+ sessionId: String): PartialFunction[Throwable, Unit] = {
+ val session =
+ SparkConnectService
+ .getOrCreateIsolatedSession(userId, sessionId)
+ .session
+ val stackTraceEnabled = try {
+ session.conf.get(
+ org.apache.spark.sql.internal.SQLConf.PYSPARK_JVM_STACKTRACE_ENABLED.key).toBoolean
+ } catch {
+ case NonFatal(_) => true
+ }
+
+ {
+ case se: SparkException if isPythonExecutionException(se) =>
+ logError(s"Error during: $opType", se)
+ observer.onError(
+ StatusProto.toStatusRuntimeException(
+ buildStatusFromThrowable(se.getCause, stackTraceEnabled)))
+
+ case e: Throwable if e.isInstanceOf[SparkThrowable] || NonFatal.apply(e) =>
+ logError(s"Error during: $opType", e)
+ observer.onError(
+ StatusProto.toStatusRuntimeException(
+ buildStatusFromThrowable(e, stackTraceEnabled)))
+
+ case e: Throwable =>
+ logError(s"Error during: $opType", e)
+ observer.onError(
+ Status.UNKNOWN
+ .withCause(e)
+ .withDescription(StringUtils.abbreviate(e.getMessage, 2048))
Review Comment:
Do we want to display the stack trace for this unknown error? What are some examples of this error?
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala:
##########
@@ -143,7 +170,13 @@ class SparkConnectService(debug: Boolean)
responseObserver: StreamObserver[proto.ExecutePlanResponse]): Unit = {
try {
new SparkConnectStreamHandler(responseObserver).handle(request)
- } catch handleError("execute", observer = responseObserver)
+ } catch {
+ handleError(
+ "execute",
+ observer = responseObserver,
+ userId = request.getUserContext.getUserId,
+ sessionId = request.getSessionId)
Review Comment:
Is it possible to throw any error when getting the UserContext and SessionId?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] allisonwang-db commented on a diff in pull request #40575: [SPARK-42945][CONNECT] Support PYSPARK_JVM_STACKTRACE_ENABLED in Spark Connect
Posted by "allisonwang-db (via GitHub)" <gi...@apache.org>.
allisonwang-db commented on code in PR #40575:
URL: https://github.com/apache/spark/pull/40575#discussion_r1154486470
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala:
##########
@@ -109,23 +118,41 @@ class SparkConnectService(debug: Boolean)
*/
private def handleError[V](
opType: String,
- observer: StreamObserver[V]): PartialFunction[Throwable, Unit] = {
- case se: SparkException if isPythonExecutionException(se) =>
- logError(s"Error during: $opType", se)
- observer.onError(
- StatusProto.toStatusRuntimeException(buildStatusFromThrowable(se.getCause)))
-
- case e: Throwable if e.isInstanceOf[SparkThrowable] || NonFatal.apply(e) =>
- logError(s"Error during: $opType", e)
- observer.onError(StatusProto.toStatusRuntimeException(buildStatusFromThrowable(e)))
-
- case e: Throwable =>
- logError(s"Error during: $opType", e)
- observer.onError(
- Status.UNKNOWN
- .withCause(e)
- .withDescription(StringUtils.abbreviate(e.getMessage, 2048))
- .asRuntimeException())
+ observer: StreamObserver[V],
+ userId: String,
+ sessionId: String): PartialFunction[Throwable, Unit] = {
+ val session =
+ SparkConnectService
+ .getOrCreateIsolatedSession(userId, sessionId)
+ .session
+ val stackTraceEnabled = try {
+ session.conf.get(
+ org.apache.spark.sql.internal.SQLConf.PYSPARK_JVM_STACKTRACE_ENABLED.key).toBoolean
+ } catch {
+ case NonFatal(_) => true
+ }
+
+ {
Review Comment:
Do you mean the try-catch block or the partial function block?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #40575: [SPARK-42945][CONNECT] Support PYSPARK_JVM_STACKTRACE_ENABLED in Spark Connect
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #40575:
URL: https://github.com/apache/spark/pull/40575#issuecomment-1515505880
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] allisonwang-db commented on a diff in pull request #40575: [SPARK-42945][CONNECT] Support PYSPARK_JVM_STACKTRACE_ENABLED in Spark Connect
Posted by "allisonwang-db (via GitHub)" <gi...@apache.org>.
allisonwang-db commented on code in PR #40575:
URL: https://github.com/apache/spark/pull/40575#discussion_r1150227406
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala:
##########
@@ -109,23 +118,41 @@ class SparkConnectService(debug: Boolean)
*/
private def handleError[V](
opType: String,
- observer: StreamObserver[V]): PartialFunction[Throwable, Unit] = {
- case se: SparkException if isPythonExecutionException(se) =>
- logError(s"Error during: $opType", se)
- observer.onError(
- StatusProto.toStatusRuntimeException(buildStatusFromThrowable(se.getCause)))
-
- case e: Throwable if e.isInstanceOf[SparkThrowable] || NonFatal.apply(e) =>
- logError(s"Error during: $opType", e)
- observer.onError(StatusProto.toStatusRuntimeException(buildStatusFromThrowable(e)))
-
- case e: Throwable =>
- logError(s"Error during: $opType", e)
- observer.onError(
- Status.UNKNOWN
- .withCause(e)
- .withDescription(StringUtils.abbreviate(e.getMessage, 2048))
- .asRuntimeException())
+ observer: StreamObserver[V],
+ userId: String,
+ sessionId: String): PartialFunction[Throwable, Unit] = {
+ val session =
+ SparkConnectService
+ .getOrCreateIsolatedSession(userId, sessionId)
+ .session
+ val stackTraceEnabled = try {
+ session.conf.get(
+ org.apache.spark.sql.internal.SQLConf.PYSPARK_JVM_STACKTRACE_ENABLED.key).toBoolean
+ } catch {
+ case NonFatal(_) => true
+ }
+
+ {
+ case se: SparkException if isPythonExecutionException(se) =>
+ logError(s"Error during: $opType", se)
+ observer.onError(
+ StatusProto.toStatusRuntimeException(
+ buildStatusFromThrowable(se.getCause, stackTraceEnabled)))
+
+ case e: Throwable if e.isInstanceOf[SparkThrowable] || NonFatal.apply(e) =>
+ logError(s"Error during: $opType", e)
+ observer.onError(
+ StatusProto.toStatusRuntimeException(
+ buildStatusFromThrowable(e, stackTraceEnabled)))
+
+ case e: Throwable =>
+ logError(s"Error during: $opType", e)
+ observer.onError(
+ Status.UNKNOWN
+ .withCause(e)
+ .withDescription(StringUtils.abbreviate(e.getMessage, 2048))
Review Comment:
Do we want to display the stack trace for this unknown error? What are some examples of this error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #40575: [SPARK-42945][CONNECT] Support PYSPARK_JVM_STACKTRACE_ENABLED in Spark Connect
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on code in PR #40575:
URL: https://github.com/apache/spark/pull/40575#discussion_r1151086910
##########
python/pyspark/sql/tests/connect/test_connect_basic.py:
##########
@@ -226,6 +226,17 @@ def test_error_handling(self):
with self.assertRaises(AnalysisException):
df.collect()
+ def test_error_stack_trace(self):
+ self.connect.conf.set("spark.sql.pyspark.jvmStacktrace.enabled", "true")
+ with self.assertRaises(AnalysisException) as e:
+ self.connect.sql("select x").collect()
+ self.assertTrue("JVM stacktrace" in e.exception.message)
Review Comment:
Can we match the true AnalysisException error messages? It should be something like `column_not_resolved`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] allisonwang-db commented on pull request #40575: [SPARK-42945][CONNECT] Support PYSPARK_JVM_STACKTRACE_ENABLED in Spark Connect
Posted by "allisonwang-db (via GitHub)" <gi...@apache.org>.
allisonwang-db commented on PR #40575:
URL: https://github.com/apache/spark/pull/40575#issuecomment-1517215527
> @HyukjinKwon @allisonwang-db it seems `UserDefinedFunctionE2ETestSuite` keeps failing after this PR
This is because the default max HTTP header size is 8k and having 2k messages and 4k stack trace exceeds this limit. For now I changed the default max stack trace size to be 2k. We should consider moving to a different error framework to remove such constraints.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #40575: [SPARK-42945][CONNECT] Support PYSPARK_JVM_STACKTRACE_ENABLED in Spark Connect
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #40575:
URL: https://github.com/apache/spark/pull/40575#issuecomment-1515733014
@HyukjinKwon @allisonwang-db it seems `UserDefinedFunctionE2ETestSuite` keeps failing after this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #40575: [SPARK-42945][CONNECT] Support PYSPARK_JVM_STACKTRACE_ENABLED in Spark Connect
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #40575:
URL: https://github.com/apache/spark/pull/40575#issuecomment-1486431066
Nice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #40575: [SPARK-42945][CONNECT] Support PYSPARK_JVM_STACKTRACE_ENABLED in Spark Connect
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on code in PR #40575:
URL: https://github.com/apache/spark/pull/40575#discussion_r1151089716
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala:
##########
@@ -143,7 +170,13 @@ class SparkConnectService(debug: Boolean)
responseObserver: StreamObserver[proto.ExecutePlanResponse]): Unit = {
try {
new SparkConnectStreamHandler(responseObserver).handle(request)
- } catch handleError("execute", observer = responseObserver)
+ } catch {
+ handleError(
+ "execute",
+ observer = responseObserver,
+ userId = request.getUserContext.getUserId,
+ sessionId = request.getSessionId)
Review Comment:
Do we need throw exceptions or assert? Assert might be proper if the `null` stuff is due to developer errors which are expected to not happen and fixed as bug
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell commented on pull request #40575: [SPARK-42945][CONNECT] Support PYSPARK_JVM_STACKTRACE_ENABLED in Spark Connect
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell commented on PR #40575:
URL: https://github.com/apache/spark/pull/40575#issuecomment-1486984947
@allisonwang-db can we do something similar for the scala side?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #40575: [SPARK-42945][CONNECT] Support PYSPARK_JVM_STACKTRACE_ENABLED in Spark Connect
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #40575: [SPARK-42945][CONNECT] Support PYSPARK_JVM_STACKTRACE_ENABLED in Spark Connect
URL: https://github.com/apache/spark/pull/40575
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] allisonwang-db commented on pull request #40575: [SPARK-42945][CONNECT] Support PYSPARK_JVM_STACKTRACE_ENABLED in Spark Connect
Posted by "allisonwang-db (via GitHub)" <gi...@apache.org>.
allisonwang-db commented on PR #40575:
URL: https://github.com/apache/spark/pull/40575#issuecomment-1512439357
@amaliujia Scala side does not have an existing SQL conf. We can certainly add this with a new config on the Scala side as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #40575: [SPARK-42945][CONNECT] Support PYSPARK_JVM_STACKTRACE_ENABLED in Spark Connect
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #40575:
URL: https://github.com/apache/spark/pull/40575#discussion_r1169559482
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala:
##########
@@ -73,19 +74,29 @@ class SparkConnectService(debug: Boolean)
classes.toSeq
}
- private def buildStatusFromThrowable(st: Throwable): RPCStatus = {
+ private def buildStatusFromThrowable(
+ st: Throwable,
+ stackTraceEnabled: Boolean = false): RPCStatus = {
val message = StringUtils.abbreviate(st.getMessage, 2048)
+ val errorInfo = ErrorInfo
+ .newBuilder()
+ .setReason(st.getClass.getName)
+ .setDomain("org.apache.spark")
+ .putMetadata("classes", compact(render(allClasses(st.getClass).map(_.getName))))
+
+ val withStackTrace = if (stackTraceEnabled) {
+ import org.apache.spark.sql.connect.config.Connect.CONNECT_JVM_STACK_TRACE_SIZE
Review Comment:
You can just import this on the top.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #40575: [SPARK-42945][CONNECT] Support PYSPARK_JVM_STACKTRACE_ENABLED in Spark Connect
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #40575:
URL: https://github.com/apache/spark/pull/40575#issuecomment-1519228572
merged to master again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org