[GitHub] [lucene-solr] jimczi commented on issue #953: LUCENE-9006: WDGF catenateAll should come before parts

[GitBox <gi...@apache.org>]

jimczi commented on issue #953: LUCENE-9006: WDGF catenateAll should come before parts
URL: https://github.com/apache/lucene-solr/pull/953#issuecomment-545575499
 
 
   > which produced: [input, 8-input, 8input]
   which looks correct; no?
   
   It depends what you consider correct ;). With GENERATE_NUMBER_PARTS the graph looks like:
   ````
   [8 input, 8-input, 8input]
     8 other
     8-other
     8other
   ````
   so `other` is one position after `8other` and `8-other` which both spans two positions.
   When GENERATE_NUMBER_PARTS is not set `other` appears at the same position than `8other` and `8-other` which now span only one position. With Alan's proposal we'd be able to create the "correct" graph by delaying the removal of `8` in the stream in order to ensure that all nodes are reachable. Not saying that it's the best solution but it would be more consistent since it feels weird to me that `8other` and `other` are considered at the same position when numbers are removed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org