You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/06/12 18:28:59 UTC
[GitHub] [cordova-plugin-inappbrowser] mrbberra opened a new issue #728: [iOS] Set StatusBarStyle from config.xml
mrbberra opened a new issue #728:
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/728
# Feature Request
## Motivation Behind Feature
With the merge of [GH-656](https://github.com/apache/cordova-plugin-inappbrowser/pull/656), the status bar now shows up with the color of the app status bar, which I've been setting using [cordova-plugin-statusbar](https://github.com/apache/cordova-plugin-statusbar). The InAppBrowser, however, still overrides the text in the status bar with `UIStatusBarStyleDefault` (black text), which is a problem if the status bar has a dark background color.
## Example
```
StatusBar.styleLightContent();
StatusBar.backgroundColorByHexString("#281e36");
```
<img width="459" alt="Screen Shot 2020-06-12 at 1 13 09 PM" src="https://user-images.githubusercontent.com/10442753/84533846-8db5a480-acae-11ea-89d7-cdbff41e4119.png">
<img width="467" alt="Screen Shot 2020-06-12 at 1 13 16 PM" src="https://user-images.githubusercontent.com/10442753/84533802-7c6c9800-acae-11ea-88ac-75ba1277e490.png">
## Feature Description
Set IAB iOS status bar color from the cordova config file. I'm imagining something like `<preference name="InAppBrowserStatusBarStyle" value="lightcontent" />`
I've got some work on this I've started I can submit a PR for- just changing the `preferredStatusBarStyle`. I guess a more complex implementation would be to add a method to modify it dynamically (since you can modify the status bar color dynamically using that plugin)... seems like overkill to me though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] dpa99c closed issue #728: [iOS] Set StatusBarStyle from config.xml
Posted by GitBox <gi...@apache.org>.
dpa99c closed issue #728:
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/728
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] mosabab commented on issue #728: [iOS] Set StatusBarStyle from config.xml
Posted by GitBox <gi...@apache.org>.
mosabab commented on issue #728:
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/728#issuecomment-643454954
You are right.
The latest PR which remove the fake statusbar generate a new issue like what you mentioned.
I think the best way to solve this new issue is to make a new options for inappbrowser like:
Statubar.lightcontent / dark theme
Statusbar.darkcontent / light theme
....
And so....
Because with introduced dark theme for iPhone devices i think it is important now to change the way that inappbrowser show the statusbar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] mosabab commented on issue #728: [iOS] Set StatusBarStyle from config.xml
Posted by GitBox <gi...@apache.org>.
mosabab commented on issue #728:
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/728#issuecomment-679446455
I have same issue here for dark theme, because statusbar at inappbrowser plugin always read the default style (black text).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] mosabab removed a comment on issue #728: [iOS] Set StatusBarStyle from config.xml
Posted by GitBox <gi...@apache.org>.
mosabab removed a comment on issue #728:
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/728#issuecomment-643454954
You are right.
The latest PR which remove the fake statusbar generate a new issue like what you mentioned.
I think the best way to solve this new issue is to make a new options for inappbrowser like:
Statubar.lightcontent / dark theme
Statusbar.darkcontent / light theme
Or as preferences in config.xml as you mentioned
....
And so....
Because with introduced dark theme for iPhone devices i think it is important now to change the way that inappbrowser show the statusbar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] DaveRand commented on issue #728: [iOS] Set StatusBarStyle from config.xml
Posted by GitBox <gi...@apache.org>.
DaveRand commented on issue #728:
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/728#issuecomment-671518216
I have a similar requirement except I need to set the statusbar background color dynamically as well as setting the statusbar text color to white.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] mosabab edited a comment on issue #728: [iOS] Set StatusBarStyle from config.xml
Posted by GitBox <gi...@apache.org>.
mosabab edited a comment on issue #728:
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/728#issuecomment-643454954
You are right.
The latest PR which remove the fake statusbar generate a new issue like what you mentioned.
I think the best way to solve this new issue is to make a new options for inappbrowser like:
Statubar.lightcontent / dark theme
Statusbar.darkcontent / light theme
Or as preferences in config.xml as you mentioned
....
And so....
Because with introduced dark theme for iPhone devices i think it is important now to change the way that inappbrowser show the statusbar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org