[GitHub] [tvm] MasterJH5574 commented on a diff in pull request #10892: [TVMScript] Fixing T.buffer with typed positional arguments other than int32

[GitBox <gi...@apache.org>]

MasterJH5574 commented on code in PR #10892:
URL: https://github.com/apache/tvm/pull/10892#discussion_r843365598


##########
src/printer/tvmscript_printer.cc:
##########
@@ -577,6 +577,9 @@ bool TVMScriptPrinter::IsSimpleBuffer(const Buffer& buf) {
     return false;
   }
   for (const PrimExpr& shp_i : buf->shape) {
+    if (shp_i.dtype() != DataType::Int(32)) {
+      return false;
+    }

Review Comment:
   Hi. It’s true that we can choose not to print in the sugar type annotation style when the shape contains `int64`, but what I’m curious is, can’t we enhance the type annotation to support `int64`? That way makes more sense, since we always want to make our stuff better and work in different cases.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org