[jira] [Commented] (CALCITE-516) GroupBy on a CASE expression containing IN predicate fails

["Aman Sinha (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14264306#comment-14264306 ] 

Aman Sinha commented on CALCITE-516:
------------------------------------

The following query with an aggregation but without group-by also fails: 

{code}
   SELECT SUM(CASE WHEN empno IN (3) THEN 0 ELSE 1 END) FROM emp;

java.lang.AssertionError: Internal error: Identifier 'EMP.EMPNO' is not a group expr
	at org.apache.calcite.util.Util.newInternal(Util.java:727)
	at org.apache.calcite.sql2rel.SqlToRelConverter.convertIdentifier(SqlToRelConverter.java:3307)
	at org.apache.calcite.sql2rel.SqlToRelConverter.access$6(SqlToRelConverter.java:3296)
	at org.apache.calcite.sql2rel.SqlToRelConverter$Blackboard.visit(SqlToRelConverter.java:4299)
	at org.apache.calcite.sql2rel.SqlToRelConverter$Blackboard.visit(SqlToRelConverter.java:1)
	at org.apache.calcite.sql.SqlIdentifier.accept(SqlIdentifier.java:271)
	at org.apache.calcite.sql2rel.SqlToRelConverter$Blackboard.convertExpression(SqlToRelConverter.java:4182)
	at org.apache.calcite.sql2rel.SqlToRelConverter.substituteSubquery(SqlToRelConverter.java:979)
	at org.apache.calcite.sql2rel.SqlToRelConverter.replaceSubqueries(SqlToRelConverter.java:937)
	at org.apache.calcite.sql2rel.SqlToRelConverter.createAggImpl(SqlToRelConverter.java:2685)
	at org.apache.calcite.sql2rel.SqlToRelConverter.convertAgg(SqlToRelConverter.java:2525)
	at org.apache.calcite.sql2rel.SqlToRelConverter.convertSelectImpl(SqlToRelConverter.java:608)
{code}

It is not clear what is the purpose of this assertion in convertIdentifier().  It just checks for {{bb.agg != null}} and throws an internal error. Removing this assert allows the query to complete and all other unit tests passed; however I am not sure if there are negative tests coverage.  

> GroupBy on a CASE expression containing IN predicate fails
> ----------------------------------------------------------
>
>                 Key: CALCITE-516
>                 URL: https://issues.apache.org/jira/browse/CALCITE-516
>             Project: Calcite
>          Issue Type: Bug
>    Affects Versions: 0.9.1-incubating
>            Reporter: Aman Sinha
>            Assignee: Julian Hyde
>              Labels: newbie
>
> The following query which does a Group-By on a CASE expression that contains IN predicate fails.  If I replace the IN with an equality or <, > the query succeeds.  I am not on latest Calcite master but I suspect the same problem exists there. 
> {code:sql}
> select (case when emp.empno in (3) then 0 else 1 end) 
>   from emp 
> group by (case when emp.empno in (3) then 0 else 1 end);
> java.lang.AssertionError: Internal error: while converting CASE WHEN `EMP`.`EMPNO` IN (3) THEN 0 ELSE 1 END
> 	at org.eigenbase.util.Util.newInternal(Util.java:750)
> 	at org.eigenbase.sql2rel.ReflectiveConvertletTable$1.convertCall(ReflectiveConvertletTable.java:93)
> 	at org.eigenbase.sql2rel.SqlNodeToRexConverterImpl.convertCall(SqlNodeToRexConverterImpl.java:52)
> 	at org.eigenbase.sql2rel.SqlToRelConverter$Blackboard.visit(SqlToRelConverter.java:4093)
> 	at org.eigenbase.sql2rel.SqlToRelConverter$Blackboard.visit(SqlToRelConverter.java:1)
> 	at org.eigenbase.sql.SqlCall.accept(SqlCall.java:125)
> 	at org.eigenbase.sql2rel.SqlToRelConverter$Blackboard.convertExpression(SqlToRelConverter.java:3988)
> 	at org.eigenbase.sql2rel.SqlToRelConverter$AggConverter.addGroupExpr(SqlToRelConverter.java:4314)
> 	at org.eigenbase.sql2rel.SqlToRelConverter.createAggImpl(SqlToRelConverter.java:2240)
> 	at org.eigenbase.sql2rel.SqlToRelConverter.convertAgg(SqlToRelConverter.java:2191)
> 	at org.eigenbase.sql2rel.SqlToRelConverter.convertSelectImpl(SqlToRelConverter.java:514)
> 	at org.eigenbase.sql2rel.SqlToRelConverter.convertSelect(SqlToRelConverter.java:474)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)