You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/28 17:13:09 UTC
[GitHub] [airflow] potiuk opened a new pull request #12690: Fix typos and added missing descriptions in provider.yaml schema
potiuk opened a new pull request #12690:
URL: https://github.com/apache/airflow/pull/12690
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #12690: Fix typos and added missing descriptions in provider.yaml schema
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #12690:
URL: https://github.com/apache/airflow/pull/12690#discussion_r532086577
##########
File path: airflow/provider.yaml.schema.json
##########
@@ -144,7 +150,7 @@
"type": "object",
"properties": {
"how-to-guide": {
Review comment:
The transfer operators are treated specially because they related with two integration. The rest can be found in one guide for a specific integration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #12690: Fix typos and added missing descriptions in provider.yaml schema
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #12690:
URL: https://github.com/apache/airflow/pull/12690#discussion_r532070018
##########
File path: airflow/provider.yaml.schema.json
##########
@@ -144,7 +150,7 @@
"type": "object",
"properties": {
"how-to-guide": {
Review comment:
Is this how-to-guide OK here @mik-laj ? It seems to be at the integration level and it is missing in the operators/sensors/hooks so it seems strange to have it here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #12690: Fix typos and added missing descriptions in provider.yaml schema
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #12690:
URL: https://github.com/apache/airflow/pull/12690#discussion_r532070831
##########
File path: airflow/provider.yaml.schema.json
##########
@@ -144,7 +150,7 @@
"type": "object",
"properties": {
"how-to-guide": {
Review comment:
Or is it becuse we have source/target integrations here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12690: Fix typos and added missing descriptions in provider.yaml schema
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12690:
URL: https://github.com/apache/airflow/pull/12690#issuecomment-735267993
The PR needs to run all tests because it modifies core of Airflow! Please rebase it to latest master or ask committer to re-run it!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #12690: Fix typos and added missing descriptions in provider.yaml schema
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #12690:
URL: https://github.com/apache/airflow/pull/12690
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org