[GitHub] [beam] roger-mike commented on pull request #16911: [WIP][BEAM-12097] ZetaSQL OVER clause converted to Logical SQL Plan

[GitBox <gi...@apache.org>]

roger-mike commented on pull request #16911:
URL: https://github.com/apache/beam/pull/16911#issuecomment-1064306954


   Hi @ibzib @apilloud. I have some questions about the equivalencies between the ZetaSQL AST and CalciteSQL AST.  For this query: 
   ```sql
   select sum(Key) over (PARTITION BY Value), count(Key) over (ORDER BY Key) From KeyValue
   ```
   We get the following AST:
   ![Screen Shot 2022-03-01 at 16 26 43](https://user-images.githubusercontent.com/61989986/157715464-a1c26e24-23ef-459b-a81f-858313deccf5.png)
   
   I'm still trying to work out the conversion of the inner classes needed for ```LogicalWindow```. I think the ```ResolvedAnalyticFunctionGroup``` could be mapped to a ```Window.Group``` but still not sure how to convert ```ResolvedWindowPartitioning```, ```ResolvedWindowOrdering```, ```ResolvedAnalyticFunctionCall```.
   
   How do you find these equivalencies? Could you give me some suggestions on how to convert this AST? Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org