[GitHub] [ignite] ivandasch commented on a diff in pull request #10709: IGNITE-15629 Persistence commands implemented

["ivandasch (via GitHub)" <gi...@apache.org>]

ivandasch commented on code in PR #10709:
URL: https://github.com/apache/ignite/pull/10709#discussion_r1194279083


##########
modules/core/src/main/java/org/apache/ignite/internal/management/persistence/PersistenceAbstractCommand.java:
##########
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.management.persistence;
+
+import java.util.List;
+import java.util.function.Consumer;
+import org.apache.ignite.internal.management.api.ComputeCommand;
+import org.apache.ignite.internal.management.persistence.PersistenceCommand.PersistenceCleanAllTaskArg;
+import org.apache.ignite.internal.management.persistence.PersistenceCommand.PersistenceCleanCorruptedTaskArg;
+import org.apache.ignite.internal.management.persistence.PersistenceCommand.PersistenceTaskArg;
+import org.apache.ignite.internal.visor.persistence.PersistenceTask;
+import org.apache.ignite.internal.visor.persistence.PersistenceTaskResult;
+import org.apache.ignite.lang.IgniteBiTuple;
+import static org.apache.ignite.internal.management.api.CommandUtils.INDENT;
+
+/** */
+public abstract class PersistenceAbstractCommand implements ComputeCommand<PersistenceTaskArg, PersistenceTaskResult> {
+    /** {@inheritDoc} */
+    @Override public Class<PersistenceTask> taskClass() {
+        return PersistenceTask.class;
+    }
+
+    /** {@inheritDoc} */
+    @Override public void printResult(PersistenceTaskArg arg, PersistenceTaskResult res, Consumer<String> printer) {
+        if (!res.inMaintenanceMode())
+            printer.accept("Persistence command can be sent only to node in Maintenance Mode.");
+        //info command

Review Comment:
   What do you think about moving the comment to the next line after the curly bracket?
   Looks a little bit weird, TBH



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org