[GitHub] yestaro edited a comment on issue #281: jewel validators

[GitBox <gi...@apache.org>]

yestaro edited a comment on issue #281: jewel validators
URL: https://github.com/apache/royale-asjs/pull/281#issuecomment-417857426
 
 
   Hi Carlos
   Thank you for merging the code.
   
   1.  I will check IE11 problem.  Because I am not sure if the Validator is suitable for Jewel, so I did not full test, only test it on Chrome,
   1.  the "action" attribute, I rename it to "valid" attribute. 
     In my first version, the FormValidator behavior as following
   - when succeeds, will dispatch "action" event
   - when fails, if user has set FormValidator.requiredFieldError, will alert the message.
   
   But then I change FormValidator behavior
   - when successed, dispatch "valid" event  
   - when fails, dispatch "invalid" event
   <Form action="..." is as web developer knows, but "valid" / "invalid" event is more like old flex.
   
   I think I will modify the code again, back to "action" event, <Form action=""> that is as web developer knows
   - when successed, dispatch "action" event  
   - when fails, dispatch "invalid" event, and if user has set FormValidator.requiredFieldError, alert the message.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services