You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by woowahan-jaehoon <gi...@git.apache.org> on 2018/06/05 11:49:35 UTC

[GitHub] zeppelin pull request #3005: [ZEPPELIN-3528] Ordering by interpreter name in...

GitHub user woowahan-jaehoon opened a pull request:

    https://github.com/apache/zeppelin/pull/3005

    [ZEPPELIN-3528] Ordering by interpreter name in same interpreter group

    ### What is this PR for?
    In 'Create new note' diagram, 'Default Interpreter' is ordered by only interpreter groups.
    
    But interpreter is not ordered in same interpreter group.
    (It seems to ordered by hashcode of 'InterpreterSetting')
    
    When there are many interpreter in same group and this group is first,
    user cannot predict what interpreter is showed first.
    
    So I think that interpreter need to be ordered by name.
    
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    * [v] - Modify Code
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-3528
    
    ### How should this be tested?
    * Click 'create new note'
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update?
        * No
    * Is there breaking changes for older versions?
        * No
    * Does this needs documentation?
        * No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/woowabros/zeppelin ZEPPELIN-3528

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/3005.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3005
    
----
commit 5f74d3a8011ec0b31885938651fe42d50d51e464
Author: Jaehoon Jeong <ja...@...>
Date:   2018-06-05T11:39:55Z

    [ZEPPELIN-3528] Ordering by interpreter name in same interpreter group

----


---

[GitHub] zeppelin pull request #3005: [ZEPPELIN-3528] Ordering by interpreter name in...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/3005


---

[GitHub] zeppelin issue #3005: [ZEPPELIN-3528] Ordering by interpreter name in same i...

Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/3005
  
    LGTM


---