[jira] Commented: (MAPREDUCE-1148) SQL identifiers are a superset of Java identifiers

["Tom White (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781509#action_12781509 ] 

Tom White commented on MAPREDUCE-1148:
--------------------------------------

+1 looks good overall.

If you made JAVA_RESERVED_WORDS a HashSet then isReservedWord() would be a one-liner.

> SQL identifiers are a superset of Java identifiers
> --------------------------------------------------
>
>                 Key: MAPREDUCE-1148
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1148
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: contrib/sqoop
>            Reporter: Aaron Kimball
>            Assignee: Aaron Kimball
>         Attachments: MAPREDUCE-1148.patch
>
>
> SQL identifiers can contain arbitrary characters, can start with numbers, can be words like {{class}} which are reserved in Java, etc. If Sqoop uses these names literally for class and field names then compilation errors can occur in auto-generated classes. SQL identifiers need to be cleansed to map onto Java identifiers.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.