You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/12/17 03:36:31 UTC

[GitHub] [incubator-doris] morningman opened a new pull request #5100: [Bug] Fix tablet shared ptr circular reference causing the tablet not to be cleared

morningman opened a new pull request #5100:
URL: https://github.com/apache/incubator-doris/pull/5100


   ## Proposed changes
   
   Regardless of whether the tablet is submitted for compaction or not,
   we need to call 'reset_compaction' to clean up the base_compaction or cumulative_compaction objects
   in the tablet, because these two objects store the tablet's own shared_ptr.
   If it is not cleaned up, the reference count of the tablet will always be greater than 1,
   thus cannot be collected by the garbage collector. (TabletManager::start_trash_sweep)
   
   This bug is introduced from #4891
   
   ## Types of changes
   
   - [x] Bugfix (non-breaking change which fixes an issue)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] morningman merged pull request #5100: [Bug] Fix tablet shared ptr circular reference causing the tablet not to be cleared

Posted by GitBox <gi...@apache.org>.
morningman merged pull request #5100:
URL: https://github.com/apache/incubator-doris/pull/5100


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org